1015896 - [tarako] unable to add new group call after Communication app is killed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Peipei Cheng (needinfo if you need my action)]

Attachment: slog.zip

Steps to reproduce
--------------------------------------------------------------------
1. Make a call and establish the call connection
2. Use adb shell to kill Communication app (this is to simulate the case that Communication is killed by OOM/LMK)
3. Try to add a new call on device
   --> The second call was always ended automatically.

Please see attached slog.

Test build
---------------------------------------------------------------------------
Gaia      ffa388c3c00ee7a31216b397acaa07e1cf94bb39
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/79eb01b64ed6
BuildID   20140525164003
Version   28.1
ro.build.version.incremental=eng.cltbld.20140520.195709
ro.build.date=Tue May 20 19:57:15 EDT 2014

Comment 1

[shawn ku [:sku]]

Hi Aknow:
 Please help check this issue first per offline talk.

Thanks!!
Shawn

Comment 2

[shawn ku [:sku]]

01-01 00:15:03.180    85    85 I Gecko   : TelephonyProvider: Dialing 13312181721

01-01 00:15:03.570    96   350 D RILC    : [0086]> DIAL (num=13312181721,clir=0)
01-01 00:15:03.590    96   350 D RILC    : [0086]< DIAL
01-01 00:15:04.030    96   349 D RILC    : [0087]< GET_CURRENT_CALLS {[id=1,ACTIVE,toa=161,norm,mt,als=0,voc,noevp,02284841399,cli=0,name='(null)',0}

01-01 00:15:04.180    85    85 I Gecko   : TelephonyProvider: handleCallDisconnected: {"number":"13312181721","state":2,"callIndex":4294967295,"isOutgoing":true,"isEmergency":false,"isConference":false,"failCause":"UnspecifiedError"}

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: 0001-telephony-should-wait-for-initialization.patch

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

In gaia, we have to make sure the telephony object is fully initialized; then we could perform the operations on it or read its attribute value. The completion of initializing is synchronized by 1st 'callschanged' event. So in the case of this issue, we should ensure that the event is received before calling telephony.dial().

attachment 8429148 [details] [diff] [review] shows a sample modification based on this idea and I have verified it.


Etienne,

Could you take this bug and provide a formal patch on gaia? Thank you.

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Szu-Yu Chen [:aknow] from comment #4)
> In gaia, we have to make sure the telephony object is fully initialized;
> then we could perform the operations on it or read its attribute value. The
> completion of initializing is synchronized by 1st 'callschanged' event. So
> in the case of this issue, we should ensure that the event is received
> before calling telephony.dial().
> 
> attachment 8429148 [details] [diff] [review] shows a sample modification
> based on this idea and I have verified it.
> 
> 
> Etienne,
> 
> Could you take this bug and provide a formal patch on gaia? Thank you.

Yes I can provide a 1.3t patch but I really think there should be a gecko patch for this on trunk if the issue happens elsewhere.

Comment 6

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR against 1.3t

?w=1 recommended

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 8429294 [details]
Gaia PR against 1.3t

>https://github.com/mozilla-b2g/gaia/pull/19678/files

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 8429294 [details]
Gaia PR against 1.3t

https://github.com/mozilla-b2g/gaia/pull/19678/files

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 8429294 [details]
Gaia PR against 1.3t

Comments left on the PR.

Comment 10

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Etienne Segonzac (:etienne) from comment #5)
> (In reply to Szu-Yu Chen [:aknow] from comment #4)
> > In gaia, we have to make sure the telephony object is fully initialized;
> > then we could perform the operations on it or read its attribute value. The
> > completion of initializing is synchronized by 1st 'callschanged' event. So
> > in the case of this issue, we should ensure that the event is received
> > before calling telephony.dial().
> > 
> > attachment 8429148 [details] [diff] [review] shows a sample modification
> > based on this idea and I have verified it.
> > 
> > 
> > Etienne,
> > 
> > Could you take this bug and provide a formal patch on gaia? Thank you.
> 
> Yes I can provide a 1.3t patch but I really think there should be a gecko
> patch for this on trunk if the issue happens elsewhere.

You are right. We are thinking about how to return an already initialized object for navigator.mozTelephony.

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 8429294 [details]
Gaia PR against 1.3t

updated

Comment 12

[Etienne Segonzac (:etienne)]

The patch is ready to go if we get 1.3t+/1.3t-approval, otherwise we can close this bug :)

Comment 13

[Ken Chang[:kenkai]]

Hi Etienne, Should we keep this bug in RIL component? I would like to file a bug for comment 10.

Comment 14

[Etienne Segonzac (:etienne)]

(In reply to Ken Chang[:ken] from comment #13)
> Hi Etienne, Should we keep this bug in RIL component? I would like to file a
> bug for comment 10.

I think we should file a follow up for the RIL fix on central.
This one is already 1.3t+, marked tarako-only etc...

Comment 15

[Ken Chang[:kenkai]]

(In reply to Etienne Segonzac (:etienne) from comment #14)
> (In reply to Ken Chang[:ken] from comment #13)
> > Hi Etienne, Should we keep this bug in RIL component? I would like to file a
> > bug for comment 10.
> 
> I think we should file a follow up for the RIL fix on central.
> This one is already 1.3t+, marked tarako-only etc...

Done, it is bug 1018045

Comment 16

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/1cd5f640a586a2f8c46af8f9de85b2792d511f1d

Comment 17

[helloarvin]

[Blocking Requested - why for this release]: According the discussions in bug1061210, this issue also exists in the branch v1.4 and we should land the patch to fix it.

Thanks a lot:)

Comment 18

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Vance, you may want to triage this for 1.4.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v1.4 is EOL