Open
Bug 1015925
Opened 11 years ago
Updated 2 years ago
HTTP cache v2: try to lower the footprint
Categories
(Core :: Networking: Cache, defect, P3)
Tracking
()
NEW
People
(Reporter: mayhemer, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-backlog])
- the cache file layers use internal "interfaces" that don't need to be actual xpcom like interfaces implementing nsISupports with QueryInterface
- the interfaces should not have virtual methods but rather a default { MOZ_CRASH("Not implemented"); } bodies ; I can on and on see all over the code reimplementation of all methods of several interfaces with just { return NS_OK; } or { MOZ_CRASH("..."); }
|
Reporter | |
Comment 1•11 years ago
|
||
(In reply to Honza Bambas (:mayhemer) from comment #0)
> - the cache file layers use internal "interfaces" that don't need to be
> actual xpcom like interfaces implementing nsISupports with QueryInterface
> - the interfaces should not have virtual methods but rather a default {
> MOZ_CRASH("Not implemented"); } bodies ; I can on and on see all over the
> code reimplementation of all methods of several interfaces with just {
> return NS_OK; } or { MOZ_CRASH("..."); }
should not have s/virtual/abstract/ methods !
|
|
Reporter | |
Updated•10 years ago
|
|
||
Updated•9 years ago
|
Whiteboard: [necko-backlog]
|
||
Comment 2•7 years ago
|
||
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
|
|
||
Comment 3•7 years ago
|
||
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P1 → P3
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•