Open Bug 1015925 Opened 10 years ago Updated 2 years ago

HTTP cache v2: try to lower the footprint

Categories

(Core :: Networking: Cache, defect, P3)

Product:
Core
Component:
Networking: Cache
Platform:
x86_64
Windows 7
Type:
defect

Tracking

()

People

(Reporter: mayhemer, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-backlog]) 

- the cache file layers use internal "interfaces" that don't need to be actual xpcom like interfaces implementing nsISupports with QueryInterface
- the interfaces should not have virtual methods but rather a default { MOZ_CRASH("Not implemented"); } bodies ; I can on and on see all over the code reimplementation of all methods of several interfaces with just { return NS_OK; } or { MOZ_CRASH("..."); }
(In reply to Honza Bambas (:mayhemer) from comment #0)
> - the cache file layers use internal "interfaces" that don't need to be
> actual xpcom like interfaces implementing nsISupports with QueryInterface
> - the interfaces should not have virtual methods but rather a default {
> MOZ_CRASH("Not implemented"); } bodies ; I can on and on see all over the
> code reimplementation of all methods of several interfaces with just {
> return NS_OK; } or { MOZ_CRASH("..."); }

should not have s/virtual/abstract/ methods !
Blocks: cache2polish
No longer blocks: cache2afterenable
Whiteboard: [necko-backlog]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P1 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.