Closed Bug 1015942 Opened 8 years ago Closed 8 years ago

tracking bug for build and release of thunderbird 31.0

Categories

(Release Engineering :: Release Requests, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: pmoore)

References

Details

Attachments

(9 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #905138 +++
Assignee: nobody → rail
Summary: tracking bug for build and release of thunderbird 24.0 → tracking bug for build and release of thunderbird 31.0
Depends on: 1035805
FTR, mgerva was kind to setup TBPL, graph server, the hooks and treestatus as a part of Firefox esr31.

The patches above are supposed to land whenever we are ready for Thunderbird 31 release (on the merge day).
Attached patch tb31-tools.diffSplinter Review
Attachment #8452312 - Flags: review?(nthomas)
Attached patch tb31-buildbot-configs.diff (obsolete) — Splinter Review
* s/comm-esr24/comm-esr31/
* rename release configs and templates
* rename l10n file for nightlies
* rename a directory under mozilla2 (we still use that mozconfig for source tarballs)
Attachment #8452313 - Flags: review?(nthomas)
Comment on attachment 8452312 [details] [diff] [review]
tb31-tools.diff

r+ if there is going to be no overlap at all between comm-esr24 and 31.
Attachment #8452312 - Flags: review?(nthomas) → review+
Comment on attachment 8452313 [details] [diff] [review]
tb31-buildbot-configs.diff

r+ with changes on landing.

>diff --git a/mozilla/release-thunderbird-comm-esr24.py.template b/mozilla/release-thunderbird-comm-esr31.py.template
>     'mozilla': {
>         # XXX remove js/src/config/milestone.txt when setting up ESR31

Please do this so tagging doesn't fail.

>diff --git a/mozilla/staging_release-thunderbird-comm-esr24.py.template b/mozilla/staging_release-thunderbird-comm-esr31.py.template
>     'mozilla': {
>         # XXX remove js/src/config/milestone.txt when setting up ESR31

Comment can go too.
Attachment #8452313 - Flags: review?(nthomas) → review+
Ooops. Updated patch with comments and js/src/config/milestone.txt removed.
Attachment #8452313 - Attachment is obsolete: true
Attachment #8452829 - Flags: review+
I synced the repo from comm-beta https://tbpl.mozilla.org/?tree=Thunderbird-Esr31&rev=889e445119fa to trigger the automation. Some of the in-tree configs/scripts (client.py at least) should be updated as a part of the merge push (ATM the builds use releases/mozilla-beta instead of releases/mozilla-esr31).
Attached patch l10nUsePymakeSplinter Review
l10nUsePymake should be set to True (as in beta)
Attachment #8456137 - Flags: review?(bhearsum)
Comment on attachment 8456137 [details] [diff] [review]
l10nUsePymake

Review of attachment 8456137 [details] [diff] [review]:
-----------------------------------------------------------------

Probably don't need to touch the non-templates, but it doesn't hurt.
Attachment #8456137 - Flags: review?(bhearsum) → review+
Comment on attachment 8456137 [details] [diff] [review]
l10nUsePymake

(In reply to Ben Hearsum [:bhearsum] from comment #12)
> Probably don't need to touch the non-templates, but it doesn't hurt.

Yeah. I just wanted to see release runner commit diffs clearer.

https://hg.mozilla.org/build/buildbot-configs/rev/e52ce5cfec61
and merged to production (no reconfig required ATM): https://hg.mozilla.org/build/buildbot-configs/rev/c20448c69517
Attachment #8456137 - Flags: checked-in+
Just to update the patch list from comment 9:
https://hg.mozilla.org/build/buildbot-configs/raw-rev/561f13274c6e
Attachment #8456150 - Flags: review+
Attachment #8456150 - Flags: checked-in+
In case we decide to build 24.7.0 without updates.

* Adds back comm-esr24
* scripts/updates/balrog-release-pusher.py conditially appends release_config['releaseChannel'] to the list of updateChannels to make it possible to not barf if the config has those set to [] and None (see next patch).
Attachment #8456384 - Flags: review?(bhearsum)
Comments will be posted in the next comment.
Attachment #8456386 - Flags: review?(bhearsum)
Attachment #8456384 - Flags: review?(bhearsum) → review+
Attachment #8456386 - Flags: review?(bhearsum) → review+
11:01:14       rail │ Standard8: are we ok with havin 24.7.0 as a "fork" without updates?
11:09:23 @Standard8 │ rail: yes, I think so - would we be able to get users to update from it in future once we dump 24.x?
11:10:53       rail │ Standard8: we will be generating updates for everything up to 24.6.0 right away; later we can manually generate updates for those who manually downloaded in installed 24.7.0+, sure 

I'm going to proceed with this plan and land the patches.
in production
Attached patch throttleSplinter Review
According to IRC we are going completely throttled
Attachment #8457968 - Flags: review?(bhearsum)
Attachment #8457968 - Flags: review?(bhearsum) → review+
It turns out that the build system (ab)uses MOZ_UPDATE_CHANNEL in many places. It's better to revert this change and probably go with a build2. :(
Attachment #8458095 - Flags: review?(bhearsum)
Comment on attachment 8458095 [details] [diff] [review]
releaseChannel.diff

Review of attachment 8458095 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh. Is there a bug on fixing the build system to make this decision in a better way? Why isn't this a mozconfig option?
Attachment #8458095 - Flags: review?(bhearsum) → review+
(In reply to Ben Hearsum [:bhearsum] from comment #24) 
> Ugh. Is there a bug on fixing the build system to make this decision in a
> better way? Why isn't this a mozconfig option?

No idea. I'll check when I'm done with this.
In production.
Comment on attachment 8457968 [details] [diff] [review]
throttle

cvs commit -m "Bug 1015942 - tracking bug for build and release of thunderbird 31.0. r=bhearsum"
Checking in config-dist.php;
/cvsroot/mozilla/webtools/aus/xml/inc/config-dist.php,v  <--  config-dist.php
new revision: 1.304; previous revision: 1.303
done
Attachment #8457968 - Flags: checked-in+
Depends on: 1042016
Done!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Required when setting up a new staging master...
Assignee: rail → pmoore
Status: RESOLVED → REOPENED
Attachment #8477379 - Flags: review?(rail)
Resolution: FIXED → ---
Attachment #8477379 - Flags: review?(rail) → review+
Awesome, thanks Kim! :)

Landed on default: https://hg.mozilla.org/build/buildbot-configs/rev/8c5ae0f39459
Thanks for the fix!
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
In production with reconfig on 2014-08-25 08:49 PT
You need to log in before you can comment on or make changes to this bug.