1015974 - Regression: Animated Sync spinning during no Sync activity and with no account

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Launch Nightly, see spinning icon. Round and round it goes, where it stops, nobody knows.

--
Nightly (05/26)
Nexus 5 (Android 4.4.2)

Comment 1

[Ian Barlow (:ibarlow)]

I have an account set up and I am also seeing the infinite spin. http://mickeygarf889.tripod.com/sitebuildercontent/sitebuilderpictures/spinners.gif

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Aaron Train [:aaronmt] from comment #0)
> Launch Nightly, see spinning icon. Round and round it goes, where it stops,
> nobody knows.

Yeah, I just saw this.  No account, spinning icon.  I'll dig into this today.

Comment 3

[Nick Alexander :nalexander [he/him]]

Ah, Android.  Appears to be a KitKat change: http://stackoverflow.com/q/21699985.  Yet another thing to work-around...

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Prophylactically stop Sync icon animation on creation. r=rnewman

It appears that Android 4.4.2 is a special snow-flake that starts the
animation on creation: http://stackoverflow.com/q/21699985.  This patch
works around that special behaviour.

Don't you love when you need to update your comment -- gleaned from
working code and documentation -- to account for Android inexplicably
changing behaviour?

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8428834 [details] [diff] [review]
Prophylactically stop Sync icon animation on creation. r=rnewman

Review of attachment 8428834 [details] [diff] [review]:
-----------------------------------------------------------------

*sigh*

Did some digging, couldn't find a better way to do this, so r+ drenched in tears.

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/52fcb2df1721

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/52fcb2df1721

Comment 8

[Aaron Train [:aaronmt]]

Still seems broken. It has a mind of it's own. For a while it doesn't do anything, and then it starts spinning. No account on device.

Oh ... this happens on device rotation on my Nexus 7 (2013, 4.4.2) while the tabs tray is open.

Comment 9

[Nick Alexander :nalexander [he/him]]

Attachment: Follow-up: Only use animated Sync icon when a sync is active. r=rnewman

Android 4.4.2 makes using animation-list, start(), and stop(),
difficult.  This works around that issue by only using animation-list
when we actually want an animated icon.

Comment 10

[Richard Newman [:rnewman]]

Comment on attachment 8430194 [details] [diff] [review]
Follow-up: Only use animated Sync icon when a sync is active. r=rnewman

Review of attachment 8430194 [details] [diff] [review]:
-----------------------------------------------------------------

:(

::: mobile/android/base/tabspanel/RemoteTabsContainerPanel.java
@@ +143,5 @@
>                      lastSyncStarted = System.currentTimeMillis();
>  
> +                    // Replace the static sync icon with an animated icon, and
> +                    // start the animation. This works around an Android 4.4.2
> +                    // bug, which makes animating the animated icon unreliable.

In this case, I think explicitly referring to Bug 1015974 is worthwhile.

@@ +144,5 @@
>  
> +                    // Replace the static sync icon with an animated icon, and
> +                    // start the animation. This works around an Android 4.4.2
> +                    // bug, which makes animating the animated icon unreliable.
> +                    panel.setIconDrawable(Panel.REMOTE_TABS, R.drawable.tabs_synced_animation);

_animated ?

@@ +177,5 @@
>                      setRefreshing(false);
>  
> +                    // Replace the animated sync icon with the static sync icon.
> +                    // This works around an Android 4.4.2 bug, which makes
> +                    // animating the animated icon unreliable.

(Bug 1015974.)

Comment 11

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/a6063244f165

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a6063244f165