1016022 - Wifi tethering not restarted on unsolicited firmware restart

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

As a part of supporting wifi coexistence with other RATS, wifi firmware can sometimes intentionally clear the IFF_RUNNING running flag on the wlan0 interface when it detects a band conflict.  The framework is then expected to shutdown and restart the wifi tethering session, which as a side effect will cause a different wifi channel to be selected.

Any active wifi tethering clients at the time will see this as a momentary lose of the network.

Currently when the wifi firmware takes this action Gecko does nothing.  The wifi tethering connection is now not live, but all indications to the user remain that it's fine.  The user needs to then manually toggle tethering off/on to recover.

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Attachment: v1

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi Michael,
Since you already provided patch, would you mind taking this bug?
Feel free to re-assign if it's not the plan.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8428808 [details] [diff] [review]
v1

Review of attachment 8428808 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/NetworkUtils.cpp
@@ +188,5 @@
>    NetworkUtils::usbTetheringSuccess
>  };
>  
>  CommandFunc NetworkUtils::sUSBFailChain[] = {
> +  NetworkUtils::clearWifiTetherParms,

Do we need this here ?

Comment 4

[Michael Vines [:m1] [:evilmachines]]

(In reply to Vincent Chang[:vchang] from comment #3)
> Do we need this here ?

Err...nope!

Comment 5

[Michael Vines [:m1] [:evilmachines]]

Attachment: v2

Comment 6

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8430273 [details] [diff] [review]
v2

Review of attachment 8430273 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.

Comment 7

[Michael Vines [:m1] [:evilmachines]]

Thanks.  Try looks pretty ok: https://tbpl.mozilla.org/?tree=Try&rev=e379d6d440df

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bcda998f8f23

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bcda998f8f23

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/1ede7bb8582b

Comment 11

[Brogan Zumwalt [Inactive]]

No STR is present to create test case to address bug.