1016093 - [NFC] Lack of support for unabbreviated URI's in NDEF URI records.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kamil Leszczuk [:kamituel]]

NfcManager.formatURIRecord() does not support unabbreviated URI's in NDEF URI records.

This means that if first byte of payload is 0x00 (which, according to NFCForum-TS-RTD_URI_1.0 means content is unabbreviated), NDEF message will not be handled at all.

Steps to reproduce:

1. Use emulator with NFC support
2. Set up RE0 and LLCP
3. nfc snep put -1 -1 [208,1,VQ,AGh0dHA6Ly9tb3ppbGxhLmNvbQ,A]

What should happen:

Browser should launch with http://mozilla.com loading.

What happens:

Nothing. Reason is twofold: invalid "if" statement in formatURIRecord() causes it to return null when prefix is '' (empty string). And switch below that does not handle that case.

Comment 1

[Junichi Hashimoto]

Attachment: ndef-uri-prefix.pat

I encountered the same bug and write a tiny patch.

Comment 2

[Kamil Leszczuk [:kamituel]]

Junichi, couple of issues I have:

1) I'm working on that already - please look at "assigned to" field, it's assigned to me. Please do not waste my work by submitting your patch.

2) Your patch is invalid, it won't work.

3) Once you'll work on your own bug, you should make pull request using github, not attach patch as a file here.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8429074 [details]
ndef-uri-prefix.pat

Probably wont be an appropriate reviewer for this bug anyway :)

Comment 4

[Junichi Hashimoto]

Sorry for bothering you. I'm waiting for your fix.

Comment 5

[Kamil Leszczuk [:kamituel]]

Attachment: Pull request

Resolves this issue by:
- fixing incorrect "if" statement
- rewriting formatURIRecord() so it makes a decision based not on prefix, but on the decoded URI instead.

Unit test is there as well.

Oh, and Travis failed with "Error: Cannot find module 'sockit-to-me'". This is Node.js/npm issue, no idea why it happened.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Kamil Leszczuk from comment #5)
> Created attachment 8429548 [details] [review]
> Pull request
> 
> Resolves this issue by:
> - fixing incorrect "if" statement
> - rewriting formatURIRecord() so it makes a decision based not on prefix,
> but on the decoded URI instead.
> 
> Unit test is there as well.
> 
> Oh, and Travis failed with "Error: Cannot find module 'sockit-to-me'". This
> is Node.js/npm issue, no idea why it happened.

Do you know you could login to travis with github account and re-run your test by a re-run button? Just a note.

Comment 7

[Kamil Leszczuk [:kamituel]]

No, I didn't know that ;) Thanks, will do next time.

Comment 8

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/0e2289d11262fa9d3c0f7fe30f61ed542b48c36c