Closed Bug 1016136 Opened 11 years ago Closed 11 years ago

Replace |'s| by |/M| in en-US.dic

Categories

(Core :: Spelling checker, defect)

Product:
Core
Component:
Spelling checker
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: ananuti, Assigned: ananuti)

Details

Attachments

(2 files, 1 obsolete file)

copy&paste into textarea, no squiggly red underline
3.38 KB, text/plain
Details
patch for checkin
109.06 KB, patch
ananuti
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch bug1016136.patch (obsolete) — — Splinter Review
Attachment #8429195 - Flags: review?(ehsan)
Comment on attachment 8429199 [details] copy&paste into textarea, no squiggly red underline Nice test case! :-)
Comment on attachment 8429195 [details] [diff] [review] bug1016136.patch Review of attachment 8429195 [details] [diff] [review]: ----------------------------------------------------------------- ::: extensions/spellcheck/locales/en-US/hunspell/en-US.dic @@ +11766,5 @@ > PET/M > PFC > PG > PIN > +PJ/M Hmm, doing this will make us accept both "PJ" and "PJ's", right? That doesn't seem like what we want to do in some cases. Am I missing something?
Flags: needinfo?(ananuti)
PJ in dictionary.com http://dictionary.reference.com/browse/PJ there's no PJ in OFD but PJs http://www.oxforddictionaries.com/us/definition/american_english/PJs that line should be PJ/SM ?
Flags: needinfo?(ananuti)
(In reply to comment #5) > PJ in dictionary.com http://dictionary.reference.com/browse/PJ > > there's no PJ in OFD but PJs > http://www.oxforddictionaries.com/us/definition/american_english/PJs > > that line should be PJ/SM ? Hmm, the "PJ" in dictionary.com seems like an arbitrary abbreviation. I'm not sure if we should accept that. IOW, I think we should keep "PJ's" here. BTW the same issue exists with the lowercase version of the word.
Comment on attachment 8429195 [details] [diff] [review] bug1016136.patch Review of attachment 8429195 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment 6 addressed both for PJ's and pj's.
Attachment #8429195 - Flags: review?(ehsan) → review+
Attachment #8429195 - Attachment is obsolete: true
Attachment #8429691 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/af1f83b150f5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: