1016150 - Crash with new MP4 demuxer on HD video

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

STR:

1. On Windows 8.1 x64, make sure Nightly is up to date.
2. Pref on new demuxer, media.fragmented-mp4.exposed = true
3. Load http://people.mozilla.org/~cpearce/video/facebook-paper.mp4
4. CRASH

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix ffmpeg

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix Windows date assert

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix Windows date assert in libstagefright demuxer

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://tbpl.mozilla.org/?tree=Try&rev=7883c9fd1b41

Comment 5

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8429756 [details] [diff] [review]
Fix ffmpeg

Review of attachment 8429756 [details] [diff] [review]:
-----------------------------------------------------------------

D'oh.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8430482 [details] [diff] [review]
Fix Windows date assert in libstagefright demuxer

Review of attachment 8430482 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +727,5 @@
>  static void convertTimeToDate(int64_t time_1904, String8 *s) {
>      time_t time_1970 = time_1904 - (((66 * 365 + 17) * 24) * 3600);
>  
> +    if (time_1970 < 0) {
> +      s->clear();

Indentation.

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b70ca6c774c9
https://hg.mozilla.org/integration/mozilla-inbound/rev/7987a44a6814

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b70ca6c774c9
https://hg.mozilla.org/mozilla-central/rev/7987a44a6814