1016153 - Avoid slop in xmlparse.c:poolGrow()

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Nicholas Nethercote [inactive]]

xmlparse.c:poolGrow() does a classic clownshoes allocation -- it requests space
for 1024 chars (which are 2 bytes each) plus a few extra bytes for a header.
This amounts to slightly more than 2048 bytes, which jemalloc rounds up to
4096 bytes.

Just after starting Firefox, this slop takes up about 250 KiB. It appears to
disappear fairly quickly; I guess the XML parsing finishes and the memory is
freed. Still, definitely worth fixing.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Avoid slop in xmlparse.c:poolGrow()

The change is simple.

Comment 2

[Eric Rahm [:erahm]]

I'll check if this shows up in DMD reports on B2G.

Comment 3

[Eric Rahm [:erahm]]

bkelly checked and didn't find poolGrow in DMD reports from tarako.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef3bb9c8101b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef3bb9c8101b