Closed Bug 1016233 Opened 8 years ago Closed 8 years ago

[Collections App] Collection UI styling

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.0, tracking-b2g:backlog, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)
Project Flags:
feature-b2g 2.0
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: amirn, Assigned: ranbena)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Pull request - Background image sizing
46 bytes, text/x-github-pull-request
ranbena
: review+
Details | Review
PR - UI styling
46 bytes, text/x-github-pull-request
amirn
: review+
kgrandon
: review+
Details | Review 
The icons styling is handled by the gaia-grid component.
Styling for the header, bg image, close button is required.
Blocks: collection-app
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Whiteboard: [systemsfe]
Ran, can you take this?
Flags: needinfo?(ran)
Assignee: nobody → ran
Target Milestone: --- → 2.0 S3 (6june)
Hey Ran - something small I wanted to fix. I was going to file a bug, but then I saw this one. Hope you don't mind me adding a patch here. This patch carries over the same styling that we use in the search app and current homescreen for the full-size background and overlay.

Let me know what you think. Thanks!
Attachment #8431258 - Flags: review?(ran)
Yes it's good and I'll include it.
(Note that I will make sure the image returned by the server will fit the device screen dimension and dpi)
Flags: needinfo?(ran)
Attachment #8431258 - Flags: review?(ran) → review+
(In reply to Ran Ben Aharon (Everything.me) from comment #3)
> Yes it's good and I'll include it.
> (Note that I will make sure the image returned by the server will fit the
> device screen dimension and dpi)

Ok, landed the first part here: https://github.com/mozilla-b2g/gaia/commit/794753c7445fa5790bac3c3450367f728c83fd05. What do you guys do if it does not meet screen dimension and DPI? In the search app we currently use it anyway, do we need to do something different?
Our server renders any requested dimension on the fly so it's no problem.
Status: NEW → ASSIGNED
Attached file PR - UI styling — 
Changes:
1. Header, content, colors, sizes
2. Wallpaper behind header
3. Collection name appears before eme.init
4. BG image retrieved by screen size and dpi
Attachment #8434945 - Flags: review?(kgrandon)
Attachment #8434945 - Flags: review?(amirn)
Comment on attachment 8434945 [details] [review]
PR - UI styling

looks good!
Attachment #8434945 - Flags: review?(amirn) → review+
followups in bug 1020957
Attachment #8434945 - Flags: review?(kgrandon) → review+
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
landed https://github.com/mozilla-b2g/gaia/commit/4099f6dc3ed6388507c4613b2d53183da21b106b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0: --- → fixed
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.