Closed Bug 1016345 Opened 6 years ago Closed 6 years ago

Add memory reporting for nsHTMLCSSStyleSheet's nsDataHashtable's buffer and the buffers of its nsString keys

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 file)

We're not accounting for several KBs of memory due to not accounting for nsHTMLCSSStyleSheet's nsDataHashtable's buffer and the buffers of its nsString keys.
Typically, that is. Obviously the amount varies depending on the document.
Attached patch patchSplinter Review
Attachment #8429247 - Flags: review?(n.nethercote)
Whiteboard: [MemShrink]
Whiteboard: [MemShrink] → [MemShrink:P2]
Comment on attachment 8429247 [details] [diff] [review]
patch

Review of attachment 8429247 [details] [diff] [review]:
-----------------------------------------------------------------

dbaron is a better reviewer of this change.

(I'm good at reviewing memory reporters themselves, but the SizeOf() functions used by those memory reporters often go into areas I don't know much about, and so domain experts can often evaluate them better. If in doubt, feel free to r? me and I can forward if necessary.)
Attachment #8429247 - Flags: review?(n.nethercote) → review?(dbaron)
Comment on attachment 8429247 [details] [diff] [review]
patch

r=dbaron.  Sorry for the delay.
Attachment #8429247 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/23aa2c896825
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.