1016348 - In Firefox for Android 30+, nsIPromptService.promptUsernameAndPassword() aCheckState.value is always returned as false, even if the user checks the checkbox

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andrew Zitnay]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140506152807

Steps to reproduce:

1) Within an extension, call nsIPromptService.promptUsernameAndPassword().  For example:

var prompts = Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService);
var username = {value: 'test'};
var password = {value: 'test'};
var check = {value: false};
prompts.promptUsernameAndPassword(null, 'test', 'test', username, password, 'test', check);

2) Install the extension into Firefox for Android 30+ (beta channel is currently 30).

3) Run the code.

4) Check the checkbox and submit the dialog.


Actual results:

check.value is false


Expected results:

check.value should be true

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Fallout from Bug 968908. We're returning real objects now instead of strings so the string to boolean comparison is failing. This just uses the real booleans now.

Comment 2

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/80bb6e3621fc

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8429563 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 968908
User impact if declined: Checkboxes on dialogs always return false.
Testing completed (on m-c, etc.): Landed on fx-team just now, but wanted to get a heads up here on the uplift. I think this is important to have fixed on beta.
Risk to taking this patch (and alternatives if risky): This is low risk. Just using a boolean rather than comparing it with a string.
String or IDL/UUID changes made by this patch: None.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/80bb6e3621fc

Comment 5

[Andrew Zitnay]

So this will remain broken in Firefox 30 and 31?

Comment 6

[Aaron Train [:aaronmt]]

It's pending approval request

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8429563 [details] [diff] [review]
Patch

Looks like a low-risk fix that will help user experience, let's uplift.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c241763e5e37
https://hg.mozilla.org/releases/mozilla-beta/rev/aef210a74b69

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/aef210a74b69