1016368 - STK Dialogs new layout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: ICC New layout

From bug 1009254 UX team asked for a new layout for all STK dialogs (alerts, prompts, ...)

This bug is to track the new STK layout patch

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: ICC_ALERT.png

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: ICC_CALLMESSAGE.png

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: ICC_CONFIRM.png

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: ICC_INPUT_NORMAL.png

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: ICC_INPUT_YESNO.png

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

UX New layout: https://bug1009254.bugzilla.mozilla.org/attachment.cgi?id=8429068

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8429276 [details] [diff] [review]
ICC New layout

Review of attachment 8429276 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/system/js/icc.js
@@ +247,5 @@
> +      viewId.style.height =
> +        (window.innerHeight - keyboardHeight - StatusBar.height) + 'px';
> +    }
> +    viewId.style.height = window.innerHeight - StatusBar.height + 'px';
> +    viewId.style.marginTop = StatusBar.height + 'px';

Maybe you can move the 2 lines here into the icc_keyboardChanged method, and just call that here instead of duplicating code.

@@ +250,5 @@
> +    viewId.style.height = window.innerHeight - StatusBar.height + 'px';
> +    viewId.style.marginTop = StatusBar.height + 'px';
> +    window.addEventListener('keyboardchange', icc_keyboardChanged);
> +    window.addEventListener('keyboardhide', icc_keyboardChanged);
> +  },

You may also want to remove the event listeners when the view is closed. Otherwise this code will keeps firing even if the dialog is closed.

Comment 8

[Jason Smith [:jsmith]]

Feature request - so not blocking.

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: STK New layout patch

Your comments addressed. Also I added support for STK long descriptions (multiline).

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8430665 [details] [review]
STK New layout patch

f+ instead of r+ as I would like to see a new version of the patch.

Comment 11

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8430665 [details] [review]
STK New layout patch

Thank you Vivien,

A new version with your last comments addressed.

Comment 12

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Nits fixed & rebased.
Landed: https://github.com/mozilla-b2g/gaia/commit/6bd9e4e2eab25176d97de9b9fd9cac2c9ea7feea