1016435 - add dvorak keyboard

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[[e-mail] (:bhearsum)]

There was a dvorak keyboard at one point, I remember using it on my Unagi. On my Flame (with 2.0), there isn't one. Can this be re-enabled? I'm happy to help write/test whatever patches are necessary if someone points me in the general direction.

Comment 1

[Raniere Silva]

AFAIK the dvorak keyboard is available at Gaia source tree: https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/layouts/en-Dvorak.js.

Since this is related to Flame, could you build your own version of it and flash to the device? You just need to add ',en-Dvorak' at the end of line

~~~
GAIA_KEYBOARD_LAYOUTS?=en,pt-BR,es,de,fr,pl,zh-Hans-Pinyin
~~~

from `Makefile`.

Comment 2

[[e-mail] (:bhearsum)]

I could Flash my own, but I wouldn't be very useful as a dogfooder at that point. I guess this bug comes down to "are we willing to ship Dvorak to everyone?

Comment 3

[[e-mail] (:bhearsum)]

Attachment: re-add dvorak keyboard

David, it looks like you removed this as part of bug 884752. Obviously this keyboard isn't a blocker, but it's nice to have since it can't be added on after the fact. AFAIK this won't increase the size.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Make a request to the people that build the flame image, they are in control which keyboards are in the image. F.e. GeeksPhone builds all keyboards.

Quickfix:

GAIA_KEYBOARD_LAYOUTS?=en,pt-BR,es,de,fr,pl,zh-Hans-Pinyin APP=keyboard make install-gaia && adb shell stop b2g && adb shell start b2g

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #4)
> Make a request to the people that build the flame image, they are in control
> which keyboards are in the image. F.e. GeeksPhone builds all keyboards.

That's what I was attempting to do here. Do you know who the right person/people to talk to are?

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

No, this would change it for all of Gaia which should not be the case. I don't know who makes the Flame builds, you get it from PVT?

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #6)
> No, this would change it for all of Gaia which should not be the case.

Yep, makes sense. Clearly this patch isn't wanted, given that. Re-opening as a Flame-specific request, though.

David, do you know who I should be talking to about this?

Comment 8

[[e-mail] (:bhearsum)]

Tim or Rudy, someone on IRC suggested that you may be able to make a call here. It's pretty easy for me to make this Flame specific from the RelEng side if it's OK.

Comment 9

[David Flanagan [:djf]]

Sorry it has taken me a while to weigh in on this. The list of default keyboards was cut way back in bug 884752 because we were running out of space on certain devices in the 1.2 or 1.3 timeframe, and OTA updates were failing because they were too big.

Removing keyboards (and their autocorrect dictionaries) was an easy way to free up room.  The Dvorak keyboard doesn't have an autocorrect dictionary, so adding it won't add any significant filesize to the release.  

At the time, I picked the default set of keyboards pretty much at random. There was nothing magic about it, and adding Dvorak back in would be fine with me. It would actually be a good test of the case where there is a single autocorrect dictionary serving two different layouts.

I will defer to Tim and Rudy on this, but I don't see why this change would need to be Flame-specific.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, I agree that we could add Dvorak back into the default keyboard layout list.
Let me know if I need to submit a patch for this or you could help to do that.

Thanks.

Comment 11

[[e-mail] (:bhearsum)]

(In reply to Rudy Lu [:rudyl] from comment #10)
> Yes, I agree that we could add Dvorak back into the default keyboard layout
> list.
> Let me know if I need to submit a patch for this or you could help to do
> that.
> 
> Thanks.

Thanks Rudy. I actually put together a PR for this already. I'll re-open and point it your way.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8429410 [details] [review]
re-add dvorak keyboard

r=me.

Thank you.

Comment 13

[[e-mail] (:bhearsum)]

(In reply to Rudy Lu [:rudyl] from comment #12)
> Comment on attachment 8429410 [details] [review]
> re-add dvorak keyboard
> 
> r=me.
> 
> Thank you.

Thanks Rudy! I merged the PR.

Comment 14

[[e-mail] (:bhearsum)]

Latest update has the Dvorak keyboard again. Cheers!