Closed Bug 1016441 Opened 10 years ago Closed 9 years ago

Switch to using real-time signal in ThreadStackHelper

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

Switch to using real-time signal in ThreadStackHelper (v1)
8.97 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
Right now ThreadStackHelper uses SIGPROF which conflicts with the built-in profiler. We should switch to a real-time signal, which AFAIK is supported on all recent Linux versions.
Depends on: 1032996
Switching to using real-time signal lets us resolve conflicts with the profiler and organize our code better.
Attachment #8448978 - Flags: review?(snorp)
Comment on attachment 8448978 [details] [diff] [review]
Switch to using real-time signal in ThreadStackHelper (v1)

Review of attachment 8448978 [details] [diff] [review]:
-----------------------------------------------------------------

Bummer that this obsoletes the best hack ever (SignalTrampoline)
Attachment #8448978 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/cea3a5af4628
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.