Closed Bug 1016525 Opened 9 years ago Closed 9 years ago

Slow AddTransformedBoundsToRegion with empty event regions

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

ignore empty rects in AddTransformedBoundsToRegion
1004 bytes, patch
roc
: review+
Details | Diff | Splinter Review 
When an empty rect is transformed, its origin can move to a fractional position, and calling RoundOut() on the result gives a 1x1 rect. Doing region operations on lots of those can be expensive.

At the bottom of http://www.jasondavies.com/factorisation-diagrams/ , almost 50% of the slow scrolling can be attributed to AddTransformedBoundsToRegion processing empty rects.

I think I've fixed a similar issue before. Should we make RoundOut() keep empty rects empty?
Attachment #8429469 - Flags: review?(roc)
Comment on attachment 8429469 [details] [diff] [review]
ignore empty rects in AddTransformedBoundsToRegion

Review of attachment 8429469 [details] [diff] [review]:
-----------------------------------------------------------------

Yes!
Attachment #8429469 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/883ebdb850ac
Assignee: nobody → mstange
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
No longer depends on: 1017256
You need to log in before you can comment on or make changes to this bug.