1016576 - sideloaded app dies on launch with ThreadUtils.assertOnThreadComparison from Distribution.doInit

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

After sideloading an app and launching it against a tip build, GeckoDBUtils complains five times that browser.db is locked, after which ThreadUtils.assertOnThreadComparison asserts and the app process either dies or hangs.


The trouble starts with five pairs of these messages:

  GeckoDistribution  D  Getting file from distribution.
  GeckoDBUtils  D  Database is locked, trying to kill any zombie processes:
  /data/data/org.mozilla.fennec_myk/files/mozilla/06kgjhwc.webapp0/browser.db

Followed by:

  GeckoDBUtils  D  Failed to unlock database
  GeckoDistribution  D  Getting file from distribution.
  DatabaseUtils  E  at org.mozilla.gecko.util.ThreadUtils.assertOnThreadComparison(ThreadUtils.java:151)
  DatabaseUtils  E  at org.mozilla.gecko.util.ThreadUtils.assertNotOnUiThread(ThreadUtils.java:124)
  DatabaseUtils  E  at org.mozilla.gecko.distribution.Distribution.doInit(Distribution.java:251)
  DatabaseUtils  E  at org.mozilla.gecko.distribution.Distribution.getDistributionFile(Distribution.java:179)
  DatabaseUtils  E  at org.mozilla.gecko.distribution.Distribution.getBookmarks(Distribution.java:225)
  DatabaseUtils  E  at org.mozilla.gecko.distribution.Distribution.getBookmarks(Distribution.java:153)
  DatabaseUtils  E  at org.mozilla.gecko.db.BrowserDatabaseHelper.createDistributionBookmarks(BrowserDatabaseHelper.java:799)
  DatabaseUtils  E  at org.mozilla.gecko.db.BrowserDatabaseHelper.onCreate(BrowserDatabaseHelper.java:769)
  DatabaseUtils  E  at org.mozilla.gecko.db.AbstractPerProfileDatabaseProvider.getReadableDatabase(AbstractPerProfileDatabaseProvider.java:43)
  DatabaseUtils  E  at org.mozilla.gecko.db.BrowserProvider.query(BrowserProvider.java:621)


I see many references to the Distribution class, whose Distribution.doInit method is in the call stack; and the profile directory contains almost nothing but the browser.db file:

root@maguro:/data/data/org.mozilla.fennec_myk/files/mozilla # ll 06kgjhwc.webapp0/                                                                                                                       
-rw-rw----    1 app_64   app_64       12288 May 27 20:13 browser.db
-rw-------    1 app_64   app_64        8720 May 27 20:13 browser.db-journal
-rw-------    1 app_64   app_64          27 May 27 20:13 times.json


So I suspect a regression from bug 1014338, which changed "distribution processing to allow for delayed initialization" (although it isn't clear that we actually introduced delayed initialization in that bug).


Steps to Reproduce:

npm install -g mozilla-apk-cli
mozilla-apk-cli http://mykzilla.org/app/manifest.webapp ~/mykzilla.apk
adb install ~/mykzilla.apk
// launch Mykzilla


Expected Results: Mykzilla runs (shows page at http://www.mykzilla.org/app/).

Actual Results: Mykzilla crashes or hangs on white or dark screen.

Comment 1

[Richard Newman [:rnewman]]

Myk, could you try with the patches from the bugs blocked by that bug?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Bug 1013684 appears to fix the problem, so I suppose this is indeed a regression from bug 1014338.  Setting a dependency on bug 1013684 so we can confirm the fix and close this bug once that bug is fixed.

(Note that the app still hangs on the white screen of sorrow, but I suspect that's a different problem, perhaps a variant of bug 1013433).

Comment 3

[Myk Melez [:myk] [@mykmelez]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #2)
> Bug 1013684 appears to fix the problem, so I suppose this is indeed a
> regression from bug 1014338.  Setting a dependency on bug 1013684 so we can
> confirm the fix and close this bug once that bug is fixed.

This has indeed been fixed by that bug.


> (Note that the app still hangs on the white screen of sorrow, but I suspect
> that's a different problem, perhaps a variant of bug 1013433).

This too no longer happens, probably because of the fix for bug 1013433.