Closed Bug 1016615 Opened 6 years ago Closed 6 years ago

seer should not allow subresources to have a later timestamp than their parent

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: u408661, Assigned: jaypoulz)

Details

Attachments

(1 file, 1 obsolete file)

Right now, if a user visits www.example.com/index.html which contains a reference to www.example.com/crazyscript.js, the js entry will have a later timestamp than the index.html entry, even though they were conceptually visited at the same time. We should make sure that subresources/subhosts in the seer have their timestamps clamped to the last_load of the page/host.
Attached patch bug-1016615-fix.patch (obsolete) — Splinter Review
Attachment #8430881 - Flags: review?(hurley)
This is the link to the try server build:
https://tbpl.mozilla.org/?tree=Try&rev=df60cc5b73b1
Comment on attachment 8430881 [details] [diff] [review]
bug-1016615-fix.patch

Review of attachment 8430881 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/src/Seer.cpp
@@ +1380,5 @@
>      PRTime lastHit;
>      nsAutoCString subresource;
>      int baseConfidence, confidence;
>  
> +    // We use goto nextrow here instead of just failing, because we want

nice catch :)
Attachment #8430881 - Flags: review?(hurley) → review+
Updating commit message to show review.
Attachment #8430881 - Attachment is obsolete: true
Attachment #8430895 - Flags: review+
Keywords: checkin-needed
Pushed with some minor tweaks to the commit message. Thanks for the patch!
https://hg.mozilla.org/integration/mozilla-inbound/rev/07fb241b7891
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/07fb241b7891
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.