1016615 - seer should not allow subresources to have a later timestamp than their parent

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[u408661]

Right now, if a user visits www.example.com/index.html which contains a reference to www.example.com/crazyscript.js, the js entry will have a later timestamp than the index.html entry, even though they were conceptually visited at the same time. We should make sure that subresources/subhosts in the seer have their timestamps clamped to the last_load of the page/host.

Comment 1

[Jeremy Poulin [:jaypoulz]]

Attachment: bug-1016615-fix.patch

Comment 2

[Jeremy Poulin [:jaypoulz]]

This is the link to the try server build:
https://tbpl.mozilla.org/?tree=Try&rev=df60cc5b73b1

Comment 3

[u408661]

Comment on attachment 8430881 [details] [diff] [review]
bug-1016615-fix.patch

Review of attachment 8430881 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/src/Seer.cpp
@@ +1380,5 @@
>      PRTime lastHit;
>      nsAutoCString subresource;
>      int baseConfidence, confidence;
>  
> +    // We use goto nextrow here instead of just failing, because we want

nice catch :)

Comment 4

[Jeremy Poulin [:jaypoulz]]

Attachment: bug-1016615-fix.patch

Updating commit message to show review.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Pushed with some minor tweaks to the commit message. Thanks for the patch!
https://hg.mozilla.org/integration/mozilla-inbound/rev/07fb241b7891

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/07fb241b7891