Account for various sources of nsPresContext dark matter

NEW
Assigned to

Status

()

defect
5 years ago
2 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks 2 bugs)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 attachment)

Assignee

Description

5 years ago
No description provided.
Assignee

Comment 1

5 years ago
Posted patch part 1Splinter Review
Account for 2,496 B on OS X in static SVG-as-an-image documents
where there is no user interaction.
Attachment #8429650 - Flags: review?(n.nethercote)
Whiteboard: [MemShrink] → [MemShrink:P2]
I think mRefreshDriver is shared with the parent in some situations.
Comment on attachment 8429650 [details] [diff] [review]
part 1

Review of attachment 8429650 [details] [diff] [review]:
-----------------------------------------------------------------

If there is possible sharing here, an nsPresContext expert should review this as well.

::: layout/base/nsPresContext.cpp
@@ +2676,5 @@
> +  total += aMallocSizeOf(mEventManager);
> +  total += aMallocSizeOf(mTransitionManager);
> +  total += aMallocSizeOf(mAnimationManager);
> +  total += aMallocSizeOf(mRestyleManager);
> +  total += aMallocSizeOf(mRefreshDriver);

These are all complex structs which have things hanging off them, but this code doesn't measure those things. Each of these classes needs to be given -- or already has -- a SizeOfIncludingThis() function which should be called. For example:

  total += mEventManager->SizeOfIncludingThis()
Attachment #8429650 - Flags: review?(n.nethercote) → review-
Assignee

Updated

4 years ago
Blocks: 1054016
Assignee

Updated

2 years ago
No longer blocks: 1347543
You need to log in before you can comment on or make changes to this bug.