1016703 - Account for various sources of nsPresContext dark matter

Status: NEW

(Core :: Layout, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: part 1

Account for 2,496 B on OS X in static SVG-as-an-image documents
where there is no user interaction.

Comment 2

[Mats Palmgren (inactive)]

I think mRefreshDriver is shared with the parent in some situations.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8429650 [details] [diff] [review]
part 1

Review of attachment 8429650 [details] [diff] [review]:
-----------------------------------------------------------------

If there is possible sharing here, an nsPresContext expert should review this as well.

::: layout/base/nsPresContext.cpp
@@ +2676,5 @@
> +  total += aMallocSizeOf(mEventManager);
> +  total += aMallocSizeOf(mTransitionManager);
> +  total += aMallocSizeOf(mAnimationManager);
> +  total += aMallocSizeOf(mRestyleManager);
> +  total += aMallocSizeOf(mRefreshDriver);

These are all complex structs which have things hanging off them, but this code doesn't measure those things. Each of these classes needs to be given -- or already has -- a SizeOfIncludingThis() function which should be called. For example:

  total += mEventManager->SizeOfIncludingThis()