1016748 - [Gaia] speechSynthesis is undefined

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

Seems like we've recently had a test go perma-red in the last few hours or so. I'm filing this under gaia for now, but my assumption is that something recently landed in gecko that would cause this to break. We may want to close the gaia tree for this.

1) [system-test/unit/accessibility_test.js] system/Accessibility handleEvent toggles screenreader state after button sequence:

TypeError: this.speechSynthesis is undefined

at ar_handleEvent (http://system.gaiamobile.org:8080/js/accessibility.js:163:7)

at (anonymous) (http://system.gaiamobile.org:8080/test/unit/accessibility_test.js:39:9)

at wrapper (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at runTest (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)

at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)

at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

Comment 1

[Kevin Grandon :kgrandon]

Eitan - not really sure who to ask about this. Any ideas as to where we might look?

Comment 2

[Kevin Grandon :kgrandon]

Unit tests worked on: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1401195617/firefox-32.0a1.en-US.linux-x86_64.tar.bz2

But failed on this build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1401197063/firefox-32.0a1.en-US.linux-x86_64.tar.bz2

Comment 3

[Kevin Grandon :kgrandon]

Disabling the test for now so we don't have to close gaia. We should figure this out quickly though.

https://github.com/mozilla-b2g/gaia/commit/c2a24a1037323879c77f662229b8461eff7ea1dc

Comment 4

[Boris Zbarsky [:bzbarsky]]

The Gecko range from comment 2 is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5cb28a6e5da2&tochange=448f2153d6d3

Looks like the issue is WebIDL window.  In particular, window.speechSynthesis is only exposed in WebIDL if the media.webspeech.synth.enabled pref is set, but used to be exposed unconditionally.  That last seems a bit weird, but we've been shipping it for a while now.  :(

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Potential patch - Add media.webspeech.synth.enabled pref

Comment 6

[Kevin Grandon :kgrandon]

So it appears that even after setting the pref window.speechSynthesis is still not exposed in nightly? I need to go now but will investigate more tomorrow.

Comment 7

[Boris Zbarsky [:bzbarsky]]

> So it appears that even after setting the pref window.speechSynthesis is still not
> exposed in nightly?

Should work, for things that are loaded after the pref is set.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Crap, we really have exposed the property :(

We really need some test_interfaces -like test to ensure we don't expose properties and methods accidentally.

Comment 9

[Eitan Isaacson [:eeejay]]

oops :(

Comment 10

[Kevin Grandon :kgrandon]

I think this bug is no longer valid.

Comment 11

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.