101677 - popups should use css margins to affect positioning

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Joe Hewitt (gone)]

I should be able to put a css margin on a popup, and have it add that to it's
position.  In addition, these margins should be used with respect to the
popupAlign setting.

Comment 1

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 2

[Chris Waterson]

Should the popupAlign (topleft, topright, etc.) be controlled from style, as
well; e.g., -moz-popup-align: topleft? If so, we probably ought to map the
attribute's value into style at the content level...

Comment 3

[Joe Hewitt (gone)]

popupAlign and popupAnchor were merged into a single "position" property in the
XUL 1.0 spec, so perhaps we could add a -moz-popup-position css property.  

Anyway, can we consider that a future enhancement and just get the current patch
in? I need this fix for my outliner titletips work.

Comment 4

[Chris Waterson]

Never mind. I didn't read the surrounding code. Your changes look fine. We
should file a bug to get rid of all the insane string compares in this routine.
hyatt, what were you _thinking_? ;-)

Comment 5

[Chris Waterson]

Comment on attachment 50841 [details] [diff] [review]
patch to fix

r=waterson

Comment 6

[David Hyatt]

The string compares are a compatibility layer with the new syntax.  Yes, it
sucks, but I don't have the hand strength to patch the XUL to the new way.

Comment 7

[Mike Pinkerton (not reading bugmail)]

Is it acceptible that if both the attribute and the style are set that we apply
both margins to the x/y coordinates? If so, then r=pink. I just think that
perhaps we would want the css to supercede the attribute, if it is present.

Comment 8

[Joe Hewitt (gone)]

fixed