Closed Bug 1016813 Opened 11 years ago Closed 10 years ago

[FTU] Update to use gaia-header

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yor, Assigned: yor)

References

Details

Attachments

(3 files)

Pull request
46 bytes, text/x-github-pull-request
fcampo
: review+
fcampo
: feedback+
Details | Review
Wrong header 1
62.47 KB, image/png
Details
Wrong header 2
54.26 KB, image/png
Details
No description provided.
Blocks: gaia-header
Assignee: nobody → yor
Status: NEW → ASSIGNED
Attached file Pull request —
Attachment #8471969 - Flags: review?(francisco)
Attachment #8471969 - Flags: review?(fernando.campo)
Comment on attachment 8471969 [details] [review] Pull request Francisco is still on PTO I think, so taking it. It looks good, minor changes for style required. Please flag me for r? again when done.
Attachment #8471969 - Flags: review?(fernando.campo) → feedback+
Comment on attachment 8471969 [details] [review] Pull request Updated.
Attachment #8471969 - Flags: review?(francisco) → review?(fernando.campo)
Comment on attachment 8471969 [details] [review] Pull request Thanks for the clarifications Yan, it's good to go.
Attachment #8471969 - Flags: review?(fernando.campo) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reverted as it was crashing FTU headers. I'm sorry I let it through, bad review :( https://github.com/mozilla-b2g/gaia/commit/b584736ae20aa95b87d0efc06b10004451c599ac ni? Yan for possible fix
Status: RESOLVED → REOPENED
Flags: needinfo?(yor)
Resolution: FIXED → ---
Attached image Wrong header 1 —
Attached image Wrong header 2 —
Fernando, Do you have the latest b2g running? There was a platform bug that would cause what you are seeing and it has been fixed in the latest nightly.
Flags: needinfo?(yor)
ouch...using one from 2 days ago. Downloading the latest right now.
confirming that on latest build is working, I was using one without the b2g fix included. I'm sorry for all the mess, putting it back on master - d93c62e4cb48baa5aa58a8a3b2cd4ac8f9691c83 and thanks Yan for quick response!
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: