[Bluetooth] Update to use gaia-header

RESOLVED FIXED

Status

Firefox OS
Gaia::Bluetooth
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Yan Or, Assigned: Yan Or)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
iliu@mozilla.com, ianliu.moz@gmail.com
: review+
Details | Review | Splinter Review
Comment hidden (empty)
(Assignee)

Updated

4 years ago
Blocks: 1005830
(Assignee)

Comment 1

4 years ago
Created attachment 8429838 [details] [review]
Pull request

Kevin,

Please redirect r? as needed.  Thanks.
Attachment #8429838 - Flags: review?(kgrandon)
(Assignee)

Updated

4 years ago
Assignee: nobody → yor
Status: NEW → ASSIGNED
Comment on attachment 8429838 [details] [review]
Pull request

Hey, you should probably use the modules page (https://wiki.mozilla.org/Modules/FirefoxOS) to find the right reviewer, or use the history in github of the repo. In this case, I think it would make sense for Ian to review this perhaps.

Ian - could you please take a look at this? If you don't have time, feel free to delegate to me. Thanks!
Attachment #8429838 - Flags: review?(kgrandon) → review?(iliu)
Comment on attachment 8429838 [details] [review]
Pull request

Hi Yan, 

I leave some comment on GitHub. Since we set the header property 'hidden' dynamically, the tag 'gaia-subheader' is not working for the original property operation. So we always see the showing header 'Paired devices' when no device are paired. Shell the component plan to have the ability? Thanks.
Attachment #8429838 - Flags: review?(iliu)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8429838 [details] [review]
Pull request

Hi Ian,

Resync the patch with the latest base and added support for 'hidden' in gaia-subheader.  Please review.  Thanks.
Attachment #8429838 - Flags: review?(iliu)
Comment on attachment 8429838 [details] [review]
Pull request

Yan, the patch looks good for me without a nit on Github. Please check the comment on Github. Thanks. r=me
Attachment #8429838 - Flags: review?(iliu) → review+
Please check all tests on try-server are passed before land the patch.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.