Closed Bug 1016818 Opened 8 years ago Closed 7 years ago

[Bluetooth] Update to use gaia-header

Categories

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: yor, Assigned: yor)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
iliu
: review+
Details | Review
No description provided.
Blocks: gaia-header
Attached file Pull request
Kevin,

Please redirect r? as needed.  Thanks.
Attachment #8429838 - Flags: review?(kgrandon)
Assignee: nobody → yor
Status: NEW → ASSIGNED
Comment on attachment 8429838 [details] [review]
Pull request

Hey, you should probably use the modules page (https://wiki.mozilla.org/Modules/FirefoxOS) to find the right reviewer, or use the history in github of the repo. In this case, I think it would make sense for Ian to review this perhaps.

Ian - could you please take a look at this? If you don't have time, feel free to delegate to me. Thanks!
Attachment #8429838 - Flags: review?(kgrandon) → review?(iliu)
Comment on attachment 8429838 [details] [review]
Pull request

Hi Yan, 

I leave some comment on GitHub. Since we set the header property 'hidden' dynamically, the tag 'gaia-subheader' is not working for the original property operation. So we always see the showing header 'Paired devices' when no device are paired. Shell the component plan to have the ability? Thanks.
Attachment #8429838 - Flags: review?(iliu)
Comment on attachment 8429838 [details] [review]
Pull request

Hi Ian,

Resync the patch with the latest base and added support for 'hidden' in gaia-subheader.  Please review.  Thanks.
Attachment #8429838 - Flags: review?(iliu)
Comment on attachment 8429838 [details] [review]
Pull request

Yan, the patch looks good for me without a nit on Github. Please check the comment on Github. Thanks. r=me
Attachment #8429838 - Flags: review?(iliu) → review+
Please check all tests on try-server are passed before land the patch.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.