1016866 - Always send a notification when captive portal is detected

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Henry Chang [:hchang]]

Current system app will handle captive portal in three different ways: 

1) During FTU, show a entry sheet to view a URL reported by gecko.
2) For manually connection, launch a browser.
3) For auto connection, send a notification.

This patch is going to merge 2) into 3), that is, always send a notification whenever not in FTU, for the sake of the potential UX issue of captive portal and WISPr.

Comment 1

[Henry Chang [:hchang]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19714

Comment 2

[Henry Chang [:hchang]]

Comment on attachment 8429922 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19714

Hi Tim, per discussion yesterday, I requested a PR to move unify the non-FTU captive portal behavior to sending notification. The corresponding test case is also modified and passed all tests. I am asking for your review first. Thanks!

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8429922 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19714

This is good for 2.0 for resolving conflicts between app-handled captive portal (e.g. WISPr) and the system handled ones. 

What's the other bug for notification detail out of feature-b2g: 2.0?

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please address the dup test case in pull request and I will merge this for you.

Thanks!!

Comment 5

[Henry Chang [:hchang]]

Hi Tim, 

I already removed the dup test case and am waiting for the travis test result.
Besides, bug 1017472 is the bug for the existing issue that the captive portal 
notification will still be there to confuse user even if we already log in.

Thanks!

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/6001520d36ff3ceb37acc30c93ef15560551bc6d