1016928 - [Home2] Create build script for vertical homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Albert [:albert]]

Create build.js to generate single variant config during build process according to requirements specified in bug 1006172

Comment 1

[Albert [:albert]]

Attachment: Patch

Comment 2

[Albert [:albert]]

Comment on attachment 8430004 [details]
Patch

Added script to generate single variant for vertical homescreen.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8430004 [details]
Patch

r=yurenju if change naming rule from snake case to camel case (like search_page_enabled to searchPageEnabled)

Comment 4

[Carmen Jimenez Cabezas]

Vertical homescreen has been moved into apps/verticalhome.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1009111

Comment 5

[Albert [:albert]]

(In reply to Yuren [:yurenju] from comment #3)
> Comment on attachment 8430004 [details]
> Patch
> 
> r=yurenju if change naming rule from snake case to camel case (like
> search_page_enabled to searchPageEnabled)

The major part of snake case vars come frome old homescreen, if I change them then the init.json will change completely, is that what you want?

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

no, I meant variables like search_page_debug on line 255[1] which is used for "debug" field of init.json, and tap_effect_delay on line 208[2] which is used for "tap_effect_delay" field, we only change variables in javascript but not change anything in init.json.

but this is a minor issue for this pr, I'm fine if you file another follow-up bug for this enhancement and land it first.

[1] https://github.com/acperez/gaia/blob/bug-1016928/dev_apps/home2/build/build.js#L255
[2] https://github.com/acperez/gaia/blob/bug-1016928/dev_apps/home2/build/build.js#L208

Comment 7

[Albert [:albert]]

Comment on attachment 8430004 [details]
Patch

Moved files to apps/verticalhome and modified vars from snake case to camel case

Comment 8

[Albert [:albert]]

Master: https://github.com/mozilla-b2g/gaia/commit/920adfd797457647529ecabbb9f0543b8e8d3d2f

Comment 9

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.