[Home2] Create build script for vertical homescreen

RESOLVED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: albert, Assigned: albert)

Tracking

unspecified
2.0 S3 (6june)
x86_64
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.0 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

363 bytes, text/html
yurenju
: review+
Details
(Assignee)

Description

4 years ago
Create build.js to generate single variant config during build process according to requirements specified in bug 1006172
(Assignee)

Updated

4 years ago
Assignee: nobody → acperez
(Assignee)

Updated

4 years ago
Blocks: 1006172
(Assignee)

Comment 1

4 years ago
Created attachment 8430004 [details]
Patch
Whiteboard: [systemsfe]
(Assignee)

Comment 2

4 years ago
Comment on attachment 8430004 [details]
Patch

Added script to generate single variant for vertical homescreen.
Attachment #8430004 - Flags: review?(yurenju.mozilla)
Comment on attachment 8430004 [details]
Patch

r=yurenju if change naming rule from snake case to camel case (like search_page_enabled to searchPageEnabled)
Attachment #8430004 - Flags: review?(yurenju.mozilla) → review+
Vertical homescreen has been moved into apps/verticalhome.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1009111
Depends on: 1009111
(Assignee)

Comment 5

4 years ago
(In reply to Yuren [:yurenju] from comment #3)
> Comment on attachment 8430004 [details]
> Patch
> 
> r=yurenju if change naming rule from snake case to camel case (like
> search_page_enabled to searchPageEnabled)

The major part of snake case vars come frome old homescreen, if I change them then the init.json will change completely, is that what you want?
Flags: needinfo?(yurenju.mozilla)
no, I meant variables like search_page_debug on line 255[1] which is used for "debug" field of init.json, and tap_effect_delay on line 208[2] which is used for "tap_effect_delay" field, we only change variables in javascript but not change anything in init.json.

but this is a minor issue for this pr, I'm fine if you file another follow-up bug for this enhancement and land it first.

[1] https://github.com/acperez/gaia/blob/bug-1016928/dev_apps/home2/build/build.js#L255
[2] https://github.com/acperez/gaia/blob/bug-1016928/dev_apps/home2/build/build.js#L208
Flags: needinfo?(yurenju.mozilla)
(Assignee)

Comment 7

4 years ago
Comment on attachment 8430004 [details]
Patch

Moved files to apps/verticalhome and modified vars from snake case to camel case
Attachment #8430004 - Flags: review+ → review?(yurenju.mozilla)
Attachment #8430004 - Flags: review?(yurenju.mozilla) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0: --- → fixed
You need to log in before you can comment on or make changes to this bug.