1016929 - [mozlog] html formatter imports py.xml, doesn't declare it as a dependency

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[(not currently active) Ted Mielczarek]

We should either add the dependency or change the code to use some built-in module instead.

Comment 1

[James Graham [:jgraham]]

I remember there was a problem with making this module a dependency in marionette, but I don't clearly remember what it was.

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

It was from https://bugzilla.mozilla.org/show_bug.cgi?id=950098 and was because we didn't want to add an external python dependency. We ended up pulling in the _xmlgen.py file in tree.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

So should we do the same in mozlog as we did in marionette-client? I've just tried switching some of the Gaia UI tests to use the new HTML formatter and hit this issue in CI.

Comment 4

[James Graham [:jgraham]]

Yeah, so optional dependencies are a pain.

We can fix this without pulling everything into mozlog directly e.g. putting the py package on internal pypi (I guess it is already) and ensure that it's marked as a dep in the mozharness script.

Comment 5

[Julien Pagès (:parkouss)]

Hi,

I talked with Dave on irc, and it seems that a a solution is to do the same thing done for marionette runner, copy the source code needed: https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runner/mixins/xmlgen.py.

We could copy (again!) this file in the html formatter folder, so the dependency won't be required anymore.

jgraham, is this solution OK for you ?

Comment 6

[James Graham [:jgraham]]

I guess it works. I don't really like it but it's hard to come up with a better approach given the constraints.

Comment 7

[Julien Pagès (:parkouss)]

(In reply to James Graham [:jgraham] from comment #6)
> I guess it works. I don't really like it but it's hard to come up with a
> better approach given the constraints.

Yes, I totally agree - I don't like it neither. I don't really know every constraints here but this seems quite complicated. The bug is open since a few month and seems to annoy Dave. :) Well I take it.

Comment 8

[Julien Pagès (:parkouss)]

Attachment: html formatter imports py.xml, doesn't declare it as a dependency

I tested it locally with success. The xmlgen.py file is an exact copy of the one in marionette.

Comment 9

[James Graham [:jgraham]]

Comment on attachment 8559248 [details] [diff] [review]
html formatter imports py.xml, doesn't declare it as a dependency

Review of attachment 8559248 [details] [diff] [review]:
-----------------------------------------------------------------

Sigh.

Thanks for doing this though :)

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f306c27bc07

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f306c27bc07