1016940 - [Flame] Include device tree in boot.img

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

Now that we have proper bits in build/core/Makefile, we need to be ready for when the kernel will be buildable.

Comment 1

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/device-flame/pull/25

Please find attached a link to the github pull request. We just need to remove those bits now, everything should be fine.

Comment 2

[:gerard-majax]

https://github.com/mozilla-b2g/device-flame/commit/b7eb7a0203f8fe3659d22ecf650214d55a6d2966

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Reverted for strongly suspecting this to be the cause of mass Flame bustage.
https://github.com/mozilla-b2g/device-flame/commit/218bcff6200f9b9e054467da963b7209e43ad287

https://tbpl.mozilla.org/php/getParsedLog.php?id=40638814&tree=Mozilla-B2g30-v1.4 etc...

Comment 4

[:gerard-majax]

Looks like we cannot land this until we use the proper kernel repo ...

Comment 5

[Ed Morley [:emorley]]

Please can we test things like this locally before pushing? :-)

Comment 6

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

> 07:28:57     INFO -  => Found 0 unique DTB(s)
> 07:28:57     INFO -  chmod: cannot access `out/target/product/flame/dt.img': No such file or directory

If this means what I think it does, then we need to delete `BOARD_KERNEL_SEPARATED_DT := false` and `TARGET_NO_KERNEL := true` in the same commit, or at least the same push — we won't have any DTB files unless the kernel build is run, and the boot.img won't work without the device tree.

Comment 7

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Ed Morley [:edmorley UTC+0] from comment #5)
> Please can we test things like this locally before pushing? :-)

For what it's worth, that wouldn't have caught the breakage without a manual clobber of out/target, if an earlier build in the same tree had already built the kernel.

A try run (via gecko/b2g/config/flame/sources.xml) would have caught it, but we currently can't do the Flame image build on try.

Comment 8

[:gerard-majax]

Fixed by bug 1004195