1017045 - Wrong tabs are restored via the undo ability after closing multiple tabs at once; the last tab closed is used as the undo for all closed tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Steps to Reproduce

  * In a new tab, open http://polygon.com
  * In a new tab, open http://nvidia.com
  * In a new tab, open http://techmeme.com
  * In the tabs tray, swipe off Polygon, Nvidia, Techmeme

* 'Closed Polygon | Tap Undo' → Opens Techmeme
* 'Closed Nvidia | Tap Undo' → Opens Techmeme
* 'Closed Techmeme | Tap Undo' → Opens Techmeme


--
Nightly (05/28)
Asus Nexus 7 (2013, Android 4.4.2)

Comment 1

[:Margaret Leibovic]

Bug 1015421 would be the way to fix this. We only store one closed tab in session history, so we only have the ability to undo closing the last tab that was closed.

Comment 2

[:Margaret Leibovic]

I want to see what wesj comes up with in bug 1015421, since that should fix this problem, but to make this more robust we could also pass around tab ids.

Comment 3

[:Margaret Leibovic]

I just tested, and indeed this was fixed by bug 1015421.

Comment 4

[Flaviu Cos]

Doesn't matter how many tabs I close and how many times I tap on undo button only the last closed tab is restored.
Is this the correct behavior?

Comment 5

[Aaron Train [:aaronmt]]

(In reply to Flaviu Cos, QA [:flaviu] from comment #4)
> Doesn't matter how many tabs I close and how many times I tap on undo button
> only the last closed tab is restored.
> Is this the correct behavior?

Was this today's build, Nightly (06/04)?

Comment 6

[Flaviu Cos]

(In reply to Aaron Train [:aaronmt] from comment #5)
> Was this today's build, Nightly (06/04)?
Yes, the 2014-06-04 nightly build.

Comment 7

[Aaron Train [:aaronmt]]

This works for me as attempting the steps again as originally filed. The last tab closed is the one that re-opened. The recent toast work replaces the previous visible toast right away so if you swipe away tabs in a row, the toast and the tab it opens will match the one that is closed.