Closed Bug 1017047 Opened 5 years ago Closed 5 years ago

Undo'ing a private tab restores it as a regular tab

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 32
Tracking Status
firefox32 --- verified
fennec 32+ ---

People

(Reporter: aaronmt, Assigned: Margaret)

References

Details

(Keywords: reproducible)

Attachments

(1 file)

Steps to Reproduce

  * In a new private tab, open http://polygon.com
  * In the tabs tray, swipe off Polygon

* 'Closed Polygon | Tap Undo' → Opens a new regular tab with Polygon

Expected: Polygon restored as a private tab

--
Nightly (05/28)
Asus Nexus 7 (2013, Android 4.4.2)
Assignee: nobody → margaret.leibovic
This is probably just a matter of making sure session restore's closedTabs array know about private vs. regular tabs, and does the right thing when restoring them:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/SessionStore.js#828
tracking-fennec: ? → 32+
I'm working with what we have here to restore as much as we know about.

I'm going to file a follow-up bug to restore the session history as well. That could help lay the groundwork for bug 732752.
Attachment #8431217 - Flags: review?(bnicholson)
Attachment #8431217 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/890e30bcb834
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Verified as fixed in build 32.0a1 (2014-06-03);
Device: Google Nexus 5 (Android 4.4.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.