1017047 - Undo'ing a private tab restores it as a regular tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Steps to Reproduce

  * In a new private tab, open http://polygon.com
  * In the tabs tray, swipe off Polygon

* 'Closed Polygon | Tap Undo' → Opens a new regular tab with Polygon

Expected: Polygon restored as a private tab

--
Nightly (05/28)
Asus Nexus 7 (2013, Android 4.4.2)

Comment 1

[:Margaret Leibovic]

This is probably just a matter of making sure session restore's closedTabs array know about private vs. regular tabs, and does the right thing when restoring them:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/SessionStore.js#828

Comment 2

[:Margaret Leibovic]

Attachment: Properly restore private/desktopMode state of tab when undo-ing close tab

I'm working with what we have here to restore as much as we know about.

I'm going to file a follow-up bug to restore the session history as well. That could help lay the groundwork for bug 732752.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/890e30bcb834

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/890e30bcb834

Comment 5

[Flaviu Cos]

Verified as fixed in build 32.0a1 (2014-06-03);
Device: Google Nexus 5 (Android 4.4.2)