1017158 - two customizable UI tests cause a timeout during shutdown when we run-by-dir

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In bug 992911 we are working on adding --run-by-dir.  This is a great method for separating tests which cause side effects in other tests, but the result is a lot of tests need cleaning up before we can switch to it.

In this specific case browser/components/customizableui/test has 2 tests which cause timeouts on shutdown:
* browser_992747_toggle_noncustomizable_toolbar.js
* browser_993322_widget_notoolbar.js

These are on windows opt (apologies for not having a recent log).

If there is something in common between these tests that I could try hacking, please do offer up suggestions.

Comment 1

[:Gijs (he/him)]

I'm assuming you just mean "these tests time out" - 'yield' is a JS keyword we use for some of these tests so the summary as it was was confusing... I've changed it per my understanding of comment #0, but it'd be good if you can confirm. :-)

Can you reproduce this locally if running ./mach mochitest-browser browser/components/customizableui/test/ ? If not, is there something different about --run-by-dir ?

It's been a few days since I ran the tests on my Windows machine, but I don't recall having issues.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for correcting the use of english/javascript :)

Unfortunately I am unable to reproduce this locally- most of the bugs I file are issues that occur during automation only :(  I even have a windows loaner slave which doesn't reproduce these unless run exactly the way we run in automation (with mozharness)

Comment 3

[Vaibhav (:vaibhav1994)]

Not seeing this issue any more in the try push in which it was removed: https://tbpl.mozilla.org/?tree=Try&rev=b29343b7f367