1017191 - Follow-up: Use message.id in home banner telemetry instead of randomized id

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

See bug 979443 comment #22.

Comment 1

[Richard Newman [:rnewman]]

Margaret gets review on this one! :D

Comment 2

[Chenxia Liu [:liuche]]

Attachment: Patch: update home banner telemetry id

Comment 3

[:Margaret Leibovic]

Comment on attachment 8430317 [details] [diff] [review]
Patch: update home banner telemetry id

Review of attachment 8430317 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.

Comment 4

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/0d8408ae6b07

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/0d8408ae6b07

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8430317 [details] [diff] [review]
Patch: update home banner telemetry id

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 979443, change id for home banner telemetry
User impact if declined: no home banner probes
Testing completed (on m-c, etc.): manual testing
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8430317 [details] [diff] [review]
Patch: update home banner telemetry id

Aurora approval granted. Note: needed in combination with uplift of bug 979443.

Comment 8

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/43f0dcd7eca5