Closed
Bug 1017206
Opened 10 years ago
Closed 10 years ago
Update TB.js to 2.2.5
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla33
People
(Reporter: abr, Assigned: abr)
References
Details
(Whiteboard: [p=0.5, 1.5:p1, ft:webrtc, est:0.5])
Attachments
(1 file, 2 obsolete files)
102.07 KB,
patch
|
Details | Diff | Splinter Review |
From TokBox: "Here is the TB.js file which should be paired with our server release which will be deployed tomorrow (May 29th)."
Attachment #8430270 -
Flags: review?(dmose)
Assignee | ||
Comment 1•10 years ago
|
||
Diff against what we currently have in the tree. This should make it much easier to review.
Attachment #8430272 -
Flags: review?(dmose)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8430272 [details] [diff] [review] Patch: sdk.js diff from 2.2 to 2.2.5 Reassigning to Mark due to Dan's impending PTO
Attachment #8430272 -
Flags: review?(dmose) → review?(standard8)
Assignee | ||
Updated•10 years ago
|
Attachment #8430270 -
Flags: review?(dmose)
Comment 3•10 years ago
|
||
Comment on attachment 8430272 [details] [diff] [review] Patch: sdk.js diff from 2.2 to 2.2.5 As discussed on irc. This is different to what is appearing on the servers currently. It doesn't work due to a space instead of a ( on line 1418. It also messes up the css styles :-(
Attachment #8430272 -
Flags: review?(standard8) → review-
Updated•10 years ago
|
Group: mozilla-employee-confidential
Updated•10 years ago
|
Target Milestone: --- → mozilla32
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → adam
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Attachment #8430270 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8430272 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
This new version appears to be syntactically valid, and it works just fine now that the CSS has rolled out.
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/projects/elm/5a48b9b064d6
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5a48b9b064d6
Updated•10 years ago
|
Target Milestone: mozilla32 → mozilla33
Marking this verified fixed to close it out -- though this doesn't really need any testing.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•