1017276 - Closing editing mode during open animation puts toolbar into inconsistent state

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

If editing mode is cancelled during the opening animation (i.e. hitting back twice or hitting the close button post bug 997477 on tablets), the toolbar is put into an inconsistent state.

This was present before the close editing mode in one tap toolbar changes landed in 31 (bug 965548, bug 1000149), however, after these changes landed, the toolbar is unusable (as opposed to just in a strange looking state). Since no one has found this for a while, I'm assuming 30 and down are WONTFIX.

See also bug 1015450 for a similar animation inconsistency bug.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Do not close editing mode during animation.

Ideally we would combine these animating checks into one entry point to close editing mode but the telemetry makes this a little unclean. Also, we'd have to wrap cancelEdit (because it has its own return value), which is a bit annoying so I opted for the quick and easy solution.

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8430395 [details] [diff] [review]
Do not close editing mode during animation.

Review of attachment 8430395 [details] [diff] [review]:
-----------------------------------------------------------------

Same comment from bug 1015450: I'd like to understand what exactly breaks in the animation before going ahead with this.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8430395 [details] [diff] [review]
Do not close editing mode during animation.

See bug 1015450 comment #6.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/60f8de941c42

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60f8de941c42

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8430395 [details] [diff] [review]
Do not close editing mode during animation.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A

User impact if declined:
  Users who back out of the editing mode open animation by hitting back twice will put the browser into a state that can only be fixed by an OOM close of Fennec (e.g. swipe close). Note that this use case is unlikely.
 
Testing completed (on m-c, etc.): 
  Local

Risk to taking this patch (and alternatives if risky):
  Low - we may prevent the user from exiting editing mode entirely, however, the patch is small and the isAnimatingEntry variable is used elsewhere, reassuring us it may be set correctly.

String or IDL/UUID changes made by this patch: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d15101acd433