1017420 - Add support for certified apps to get the list of apps matching an activity request

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: activities-enumeration.patch

This is better solution than the one asked for in Bug 1017031.

Calling an activity with:
var activity = new MozActivity({ name: "view",
		                 data: { url: "http://foo.com" },
		                 getFilterResults: true });
activity.onsuccess = function(e) {
	console.log("** "+ JSON.stringify(activity.result) + " **");
}
activity.onerror = function(e) {
	console.log(e.error.name);
}

will just return the data that is usually sent to the activity picker.


Security wise, we check both in the child and the parent that the application is certified.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8430532 [details] [diff] [review]
activities-enumeration.patch

Review of attachment 8430532 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, though ping me before landing so we can look at the question below.

::: dom/activities/src/ActivitiesService.jsm
@@ +282,5 @@
> +        // Certified apps can ask to just get the picker data.
> +        caller.mm.sendAsyncMessage("Activity:FireSuccess",
> +          {
> +            "id": aMsg.id,
> +            "result": aResults.options

Still digging through code to try to understand what format these are in. It's not terribly important as I'm sure that there's enough data here to render the UI that we need. But I'd still like to understand the format.

Comment 2

[[:fabrice] Fabrice Desré]

The result is an array of {manifest, icon, {activity description}}. We can filter out the "description" part I guess.

[
 {"manifest":"app://wallpaper.gaiamobile.org/manifest.webapp",
  "icon":"app://wallpaper.gaiamobile.org/style/icons/64/Wallpaper.png",
  "description":{"filters":{"type":"wallpaper"},"disposition":"inline","returnValue":true,"href":"app://wallpaper.gaiamobile.org/pick.html"}},

 {"manifest":"app://gallery.gaiamobile.org/manifest.webapp",
  "icon":"app://gallery.gaiamobile.org/style/icons/Gallery_120.png",
  "description":{"filters":{"type":["image/*","image/jpeg","image/png"]},"disposition":"inline","returnValue":true,"href":"app://gallery.gaiamobile.org/index.html#pick"}},

 {"manifest":"app://camera.gaiamobile.org/manifest.webapp",
  "icon":"app://camera.gaiamobile.org/style/icons/Camera_120.png",
   "description":{"filters":{"type":["image/*","image/jpeg","video/*","video/3gpp"]},"returnValue":true,"disposition":"inline","href":"app://camera.gaiamobile.org/index.html#pick"}}
]

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Can we add the application name?

Comment 4

[[:fabrice] Fabrice Desré]

Attachment: activities-enumeration.patch v2

Now return an array of { manifestURL, iconURL, appName }, where appName is the correct localized name of the app.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8431194 [details] [diff] [review]
activities-enumeration.patch v2

Review of attachment 8431194 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/activities/src/ActivitiesService.jsm
@@ +290,5 @@
> +        let reg = DOMApplicationRegistry;
> +        let ids = [];
> +        aResults.options.forEach((aItem) => {
> +          ids.push({ id: reg._appIdForManifestURL(aItem.manifest) });
> +        });

Nit:

let ids = aResults.options.map((aItem) => {
  { id: reg._appIdForManifestURL(aItem.manifest) }
});

@@ +293,5 @@
> +          ids.push({ id: reg._appIdForManifestURL(aItem.manifest) });
> +        });
> +
> +        reg._readManifests(ids).then(
> +          function(aManifests) {

Nit: Maybe use arrow-function syntax here too?

Comment 6

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/0ad306bee50e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0ad306bee50e