Closed
Bug 1017435
Opened 10 years ago
Closed 10 years ago
[window] typo and jshint fix for app_modal_dialog
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S3 (6june)
People
(Reporter: gasolin, Unassigned)
Details
(Whiteboard: [p=1])
Attachments
(1 file)
for `AppModalDialog.prototype.getTitle` function, `if (AirplaneMode` is miss-spelled to `AirplanMode`.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8430561 -
Flags: review?(alive)
|
|
Reporter | |
Updated•10 years ago
|
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S3 (6june)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8430561 [details] [review] pull request redirect to github Good, better if you have test for AirplaneMode.
Attachment #8430561 -
Flags: review?(alive) → review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
I could add such test while implementing app_permission_dialog merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/acfcbfcd6b33ccaa8c20e59fe33a8dbcc01fa9a1 thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•