Closed
Bug 1017513
Opened 11 years ago
Closed 11 years ago
Add existing captive portal xpcshell test cases to xpcshell_b2g.ini
Categories
(Firefox OS Graveyard :: Wifi, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: hchang, Assigned: hchang)
Details
(Whiteboard: [p=1][ft:ril])
Attachments
(1 file)
|
2.10 KB,
patch
|
schien
:
review+
|
Details | Diff | Splinter Review |
We already have a couple of captive portal test cases for gecko [1]. Add them to
xpcshell_b2g.ini for auto test.
[1] http://hg.mozilla.org/mozilla-central/file/1e712b724d17/toolkit/components/captivedetect/test/unit
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → hchang
Whiteboard: [p=1][ft:ril]
| Assignee | ||
Comment 1•11 years ago
|
||
This patch adds existing captive portal tests to b2g emulator and fixes a test failure caused by Bug 892765, which forgot to remove the code from line 23 to 29 @ [1]
[1] http://hg.mozilla.org/mozilla-central/diff/8dfaa3d620fb/toolkit/components/captivedetect/test/unit/test_captive_portal_found_303.js#l1.23
| Assignee | ||
Updated•11 years ago
|
Attachment #8431471 -
Flags: review?(schien)
Comment 2•11 years ago
|
||
Comment on attachment 8431471 [details] [diff] [review]
Patch V1
Review of attachment 8431471 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for enabling these test cases again!
Attachment #8431471 -
Flags: review?(schien) → review+
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
| Assignee | ||
Comment 3•11 years ago
|
||
The try run result is on comment 36 of Bug 1010733
https://tbpl.mozilla.org/?tree=Try&rev=418cd8ee252d
Comment 4•11 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•