1017560 - Choosing the same language will modify the state of Show Translation button

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Steps to reproduce:
1. Start Firefox.
2. Load https://www.mozilla.org/fr/contribute/.
3. Click 'Translate' on the Translate infobar.
4. Click Show Original.
5. In the first dropdown field/or the second, select again the same language as the one it already is.

Expected results: Show Translation button does not switch to Show Original.

Actual results: Show Translation button switches to Show Original.

Notes:
1. Reproducible on Windows, Linux and Mac OS X
2. Screencast showing the issue - https://db.tt/7Zfw68Ea

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

This patch changes the code using _handleButtonHiding in the infobar to make it less fragile (it will now use the state saved in the TranslationUI object, rather than having hard coded parameter values after some operations).

Comment 2

[Florian Quèze [:florian]]

Marco, please add this to the current iteration.

Comment 3

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/652092f2085d

Comment 4

[Marco Mucci [:MarcoM]]

Added to Iteration 33.1

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/652092f2085d

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Verified as fixed using latest Nightly on Windows 7 64bit, Ubuntu 14.04 32bit, Ubuntu 13.04 64bit and Mac OS X 10.9.2.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8437667 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): This bug is part of the automatic translation feature, which we want to A/B test with a subset of Aurora 32 users.
User impact if declined: Infobar can be in a wrong state if the user chooses the same language in the language dropdowns
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): minimal
String or IDL/UUID changes made by this patch: none

Comment 8

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/011d04986808

Comment 9

[Bogdan Maris, Desktop Test Engineering]

Verified as fixed on Windows 7 64bit, Ubuntu 14.04 32bit and Mac OS X 10.9.3 using latest Aurora.