Closed Bug 1017567 Opened 6 years ago Closed 5 years ago

Use Actions for "open_utility_tray" method

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: AndreiH, Assigned: viorela)

Details

Attachments

(1 file, 1 obsolete file)

Priority: -- → P2
Attachment #8430802 - Flags: review?(zcampbell)
Attachment #8430802 - Flags: review?(florin.strugariu)
Attachment #8430802 - Flags: review?(florin.strugariu) → review+
Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

r- because of fail on TBPL
Attachment #8430802 - Flags: review?(zcampbell) → review-
Assignee: nobody → andrei.hutusoru
Travis was ok, so we shouldn't use actions on this for now?
Flags: needinfo?(zcampbell)
AndreiH I suspect the failure is a timing problem on Gaia-Try.
Flags: needinfo?(zcampbell)
Andreih, just ni? as a reminder to come back to this when you've some spare time!
Flags: needinfo?(andrei.hutusoru)
Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

I updated the PR
Attachment #8430802 - Flags: review- → review?(zcampbell)
Flags: needinfo?(andrei.hutusoru)
Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

r? again when it passes on CI
Attachment #8430802 - Flags: review?(zcampbell)
Ahhh, it was failing locally for me on desktop build. Fixed it and it seems that CI does not like it :|
I updated this again, I will ask for review when I am sure this passes on CI:
https://travis-ci.org/mozilla-b2g/gaia/builds/29302410
Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

The test is now passing on Travis and TBPL
Attachment #8430802 - Flags: review?(zcampbell)
Attachment #8430802 - Flags: review?(robert.chira)
Attachment #8430802 - Flags: review?(florin.strugariu)
Attachment #8430802 - Flags: review-
Attachment #8430802 - Flags: review+
Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

This still seems unstable on TBPL, I think if we merge this we can expect intermittents.
Attachment #8430802 - Flags: review?(zcampbell)
Attachment #8430802 - Flags: review?(robert.chira)
Attachment #8430802 - Flags: review?(florin.strugariu)
Attachment #8430802 - Flags: review-
I'll un-assign AndreiH as he has moved teams.

Anyone can feel free to take AndreiH's patch and try and work on the stability of it.
Assignee: andrei.hutusoru → nobody
Assignee: nobody → viorela.ioia
Attachment #8496833 - Flags: review?(zcampbell)
Attachment #8496833 - Flags: review?(robert.chira)
Attachment #8496833 - Flags: review?(florin.strugariu)
Comment on attachment 8496833 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24508

r-, the tap locations need to be relative.

Also, can you perform the action on _status_bar_locator instead as it's more meta :)
Attachment #8496833 - Flags: review?(zcampbell) → review-
Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

Making this obsolete as Viorela is working on a new pull
Attachment #8430802 - Attachment is obsolete: true
Comment on attachment 8496833 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24508

Travis is failing
Attachment #8496833 - Flags: review?(florin.strugariu) → review-
Attachment #8496833 - Flags: review?(zcampbell)
Attachment #8496833 - Flags: review?(florin.strugariu)
Attachment #8496833 - Flags: review-
Works on device but Viorela can you do an empty/force push to trigger Gaia-Try again?

Just want to be sure it's green on Try and it didn't pick up your commit when the tree was closed yesterday.
Flags: needinfo?(viorela.ioia)
Comment on attachment 8496833 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24508

gaia-try was green
Attachment #8496833 - Flags: review?(robert.chira) → review+
Done, gaia-try is green: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=002b7e5db5da
Flags: needinfo?(viorela.ioia)
Attachment #8496833 - Flags: review?(florin.strugariu) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-s1]
You need to log in before you can comment on or make changes to this bug.