1017567 - Use Actions for "open_utility_tray" method

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[[:AndreiH]]

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/system/app.py#L33

Comment 1

[[:AndreiH]]

Attachment: PR https://github.com/mozilla-b2g/gaia/pull/19767

Comment 2

[Zac C (:zac)]

Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

r- because of fail on TBPL

Comment 3

[[:AndreiH]]

Travis was ok, so we shouldn't use actions on this for now?

Comment 4

[Zac C (:zac)]

AndreiH I suspect the failure is a timing problem on Gaia-Try.

Comment 5

[Zac C (:zac)]

Andreih, just ni? as a reminder to come back to this when you've some spare time!

Comment 6

[[:AndreiH]]

Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

I updated the PR

Comment 7

[Florin Strugariu [:Bebe]]

Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

This is still failing on travis and tbpl.

Comment 8

[Zac C (:zac)]

Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

r? again when it passes on CI

Comment 9

[[:AndreiH]]

Ahhh, it was failing locally for me on desktop build. Fixed it and it seems that CI does not like it :|

Comment 10

[[:AndreiH]]

I updated this again, I will ask for review when I am sure this passes on CI:
https://travis-ci.org/mozilla-b2g/gaia/builds/29302410

Comment 11

[[:AndreiH]]

Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

The test is now passing on Travis and TBPL

Comment 12

[Zac C (:zac)]

Retriggered this a lot to check for intermittents:
https://tbpl.mozilla.org/?rev=976e1736663640474f9e63926b5cc21647669889&tree=Gaia-Try

Comment 13

[Zac C (:zac)]

Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

This still seems unstable on TBPL, I think if we merge this we can expect intermittents.

Comment 14

[Zac C (:zac)]

I'll un-assign AndreiH as he has moved teams.

Anyone can feel free to take AndreiH's patch and try and work on the stability of it.

Comment 15

[Viorela Ioia [:viorela]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24508

Comment 16

[Zac C (:zac)]

Comment on attachment 8496833 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24508

r-, the tap locations need to be relative.

Also, can you perform the action on _status_bar_locator instead as it's more meta :)

Comment 17

[Florin Strugariu [:Bebe]]

Comment on attachment 8430802 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/19767

Making this obsolete as Viorela is working on a new pull

Comment 18

[Florin Strugariu [:Bebe]]

Comment on attachment 8496833 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24508

Travis is failing

Comment 19

[Zac C (:zac)]

Works on device but Viorela can you do an empty/force push to trigger Gaia-Try again?

Just want to be sure it's green on Try and it didn't pick up your commit when the tree was closed yesterday.

Comment 20

[Robert Chira [:RobertC]]

Comment on attachment 8496833 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24508

gaia-try was green

Comment 21

[Viorela Ioia [:viorela]]

Done, gaia-try is green: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=002b7e5db5da

Comment 22

[Robert Chira [:RobertC]]

Comment on attachment 8496833 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24508

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/2d9b9e21faa7c7736626c73a873ec53832f41353