Closed Bug 1017633 Opened 9 years ago Closed 9 years ago

Refine 'clear history' feature in History panel

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec32+)

Status:
RESOLVED FIXED
Milestone:
Firefox 32
Tracking Flags:
Tracking Status
fennec 32+ ---

People

(Reporter: mfinkle, Assigned: Margaret)

References

Details

Attachments

(1 file)

Update "Clear history" dialog button and add telemetry
2.89 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
Some things to tweak:
1. The dialog prompt uses "Yes" and "Cancel". Those are oil and water. Ian suggested using "OK" and "Cancel".
2. Add some UI telemetry to track usage. We have a "sanitize" Event and a "button" Method, but let's use "history" as an Extra. Maybe update the existing sanitize Event in Settings to pass "settings" in the Extra to make it easy to split them up.
Assignee: nobody → margaret.leibovic
tracking-fennec: --- → ?
Blocks: 998009
tracking-fennec: ? → 32+
This patch address's mfinkle's feedback.

First time I'm writing a UI telemetry probe here, hopefully I'm doing this right!
Attachment #8431199 - Flags: review?(liuche)
Comment on attachment 8431199 [details] [diff] [review]
Update "Clear history" dialog button and add telemetry

looks good to me. /me steals review
Attachment #8431199 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/dc5975c76fda
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.