Refine 'clear history' feature in History panel

RESOLVED FIXED in Firefox 32

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mfinkle, Assigned: Margaret)

Tracking

Trunk
Firefox 32
x86_64
Linux
Points:
---

Firefox Tracking Flags

(fennec32+)

Details

Attachments

(1 attachment)

Some things to tweak:
1. The dialog prompt uses "Yes" and "Cancel". Those are oil and water. Ian suggested using "OK" and "Cancel".
2. Add some UI telemetry to track usage. We have a "sanitize" Event and a "button" Method, but let's use "history" as an Extra. Maybe update the existing sanitize Event in Settings to pass "settings" in the Extra to make it easy to split them up.
(Assignee)

Updated

5 years ago
Assignee: nobody → margaret.leibovic
tracking-fennec: --- → ?
Blocks: 998009
tracking-fennec: ? → 32+
(Assignee)

Comment 1

5 years ago
Created attachment 8431199 [details] [diff] [review]
Update "Clear history" dialog button and add telemetry

This patch address's mfinkle's feedback.

First time I'm writing a UI telemetry probe here, hopefully I'm doing this right!
Attachment #8431199 - Flags: review?(liuche)
Comment on attachment 8431199 [details] [diff] [review]
Update "Clear history" dialog button and add telemetry

looks good to me. /me steals review
Attachment #8431199 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/dc5975c76fda
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.