1017681 - [B2G][Flame][Browser] Tapping the refresh button will highlight the tab button as well

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Rachel Pribble [:rpribble]]

Attachment: Video.ogg

Description:
WHen the user taps the refresh or cancel button in the browser, the tap arrow will highlight as well.

Repro Steps:
1) Updated Flame to BuildID: 20140527040202
2) Launch the browser and search for a page
3) Tap the refresh/cancel button

Actual:
Tab button highlights along with the refresh or cancel button.

Expected:
Only one button is selected.

Environmental Variables:
Device: Flame v1.4 MOZ ril
BuildID: 20140527040202
Gaia: 6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko: cbe4f69c2e9c
Version: 32.0a1
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 100%
See attached: Video, logcat

Comment 1

[Rachel Pribble [:rpribble]]

Attachment: Logcat.txt

This issue also occurs on the Flame v1.4 MOZ ril.

Environmental Variables:
Device: Flame v1.4 MOZ ril
BuildID: 20140529000204
Gaia: 7bc1c15c67661a0b8e35f18f15a9d03d1d2cfcd5
Gecko: 2181cac4d0fc
Version: 30.0
Firmware Version: v1.2-device.cfg

Tap will highlight along with refresh button.

Comment 2

[Jason Smith [:jsmith]]

Does this happen on 1.3?

Comment 3

[Dale Harvey (:daleharvey)]

I believe this pretty much always happened since implemented, keep assuming it was fixed at some point

Comment 4

[Rachel Pribble [:rpribble]]

This issue does repro on the Buri v1.4 MOZ ril.

Environmental Variables:
Device: Buri v1.4 MOZ ril
BuildID: 20140523000202
Gaia: 16f7ef17feb08562aa6a3cfd6d561b2fcca652c0
Gecko: 9cc96d59cc30
Version: 30.0
Firmware Version: v1.2-device.cfg

The tab button highlights along with the refresh button.

Comment 5

[Rachel Pribble [:rpribble]]

This issue also repros on the Buri v1.3 MOZ ril.

Environmental Variables:
Device: Buri v1.3 MOZ ril
BuildID: 20140529024024
Gaia: 5bd226b03a2d63dfe9df204f7c0afb9984e8fd42
Gecko: 42ef074f380f
Version: 28.0
Firmware Version: v1.2-device.cfg

The tab button highlights along with the refresh button.

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19817

To keep this in CSS we would have make more significant changes to the layout, the JS implementation ended up cleaner

Comment 7

[Ben Francis [:benfrancis]]

Comment on attachment 8431508 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19817

Ick, OK. Make Travis green, hold nose, land, never speak of this again.

Comment 8

[Dale Harvey (:daleharvey)]

rebased and green build @ https://travis-ci.org/daleharvey/gaia/builds/26655674

Comment 9

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/89fb3d5aa079ac1f424ba39a877c4c2d321f022b