1017696 - Use a JSON storage back-end in the Login Manager - SeaMonkey part

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Philip Chee]

Encountered error during make package

> Error: c:\t1\hg\objdir-sm\suite\installer\package-manifest:337: Missing file(s): bin/components/storage-mozStorage.js

Comment 1

[Philip Chee]

Attachment: Part 1 unbreak |make package| in comm-central (SM/TB/IB) rs=Ratty

Checked in bustage fix fallout from Bug 853549
http://hg.mozilla.org/comm-central/rev/114feac4036f

Comment 2

[Philip Chee]

Attachment: Patch v1.0 Load Login data from disk off the main thread

> +++ b/suite/common/src/nsSuiteGlue.js
Firefox does this in browser.js, but we have more ways of starting SM so putting this in nsSuiteGlue.js instead.

> +        Services.console.logStringMessage('"timer-callback" called');
I'll remove this before check-in.

> +        // Load the Login Manager data from disk off the main thread, some time
Copied comment from Firefox. I don't know how this works.

Comment 3

[[e-mail]]

(In reply to Philip Chee from comment #2)
> > +        // Load the Login Manager data from disk off the main thread, some time
> Copied comment from Firefox. I don't know how this works.
When the login manager is first loaded, it triggers an async load of the passwords. If nobody needs the passwords, all well and good. If someone does need a password, it synchronously loads the passwords and ignores the results of the async load.

Comment 4

[[e-mail]]

Comment on attachment 8435826 [details] [diff] [review]
Patch v1.0 Load Login data from disk off the main thread

>+        try {
>+          Services.logins;
>+        } catch (ex) {
>+          Cu.reportError(ex);
>+        }
Nit: try/catch isn't of much use here.

Comment 5

[Philip Chee]

Attachment: Part 2 Load Login data OMT: Patch v1.1 Don't need a try/catch block.

> Nit: try/catch isn't of much use here.
Removed.

> +    timer.init(this, 3000, timer.TYPE_ONE_SHOT);
I was thinking of increasing this to 5sec. What do you think?

Comment 6

[Philip Chee]

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/3003e97f7fca