Closed Bug 1017696 Opened 6 years ago Closed 6 years ago

Use a JSON storage back-end in the Login Manager - SeaMonkey part

Categories

(SeaMonkey :: Installer, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.30

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(2 files, 1 obsolete file)

Encountered error during make package

> Error: c:\t1\hg\objdir-sm\suite\installer\package-manifest:337: Missing file(s): bin/components/storage-mozStorage.js
> +++ b/suite/common/src/nsSuiteGlue.js
Firefox does this in browser.js, but we have more ways of starting SM so putting this in nsSuiteGlue.js instead.

> +        Services.console.logStringMessage('"timer-callback" called');
I'll remove this before check-in.

> +        // Load the Login Manager data from disk off the main thread, some time
Copied comment from Firefox. I don't know how this works.
Attachment #8435826 - Flags: review?(neil)
(In reply to Philip Chee from comment #2)
> > +        // Load the Login Manager data from disk off the main thread, some time
> Copied comment from Firefox. I don't know how this works.
When the login manager is first loaded, it triggers an async load of the passwords. If nobody needs the passwords, all well and good. If someone does need a password, it synchronously loads the passwords and ignores the results of the async load.
Comment on attachment 8435826 [details] [diff] [review]
Patch v1.0 Load Login data from disk off the main thread

>+        try {
>+          Services.logins;
>+        } catch (ex) {
>+          Cu.reportError(ex);
>+        }
Nit: try/catch isn't of much use here.
> Nit: try/catch isn't of much use here.
Removed.

> +    timer.init(this, 3000, timer.TYPE_ONE_SHOT);
I was thinking of increasing this to 5sec. What do you think?
Attachment #8435826 - Attachment is obsolete: true
Attachment #8435826 - Flags: review?(neil)
Attachment #8436039 - Flags: review?(neil)
Attachment #8436039 - Flags: review?(neil) → review+
Attachment #8436039 - Attachment description: Patch v1.1 Don't need a try/catch block. → Part 2 Load Login data OMT: Patch v1.1 Don't need a try/catch block.
Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/3003e97f7fca
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.30
You need to log in before you can comment on or make changes to this bug.