Closed
Bug 1017820
Opened 10 years ago
Closed 10 years ago
Remove the classinfo for DOMWindowUtils
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
8.52 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8431078 [details] [diff] [review] Remove the classinfo for DOMWindowUtils https://tbpl.mozilla.org/?tree=Try&rev=2739094b9ab1 I've fixed the test failures after pushing to try. Note that I removed test_bug397571.html because I don't think that test makes sense any more, as the DOMWindowUtils object should not be accessible to content.
Attachment #8431078 -
Flags: review?(bzbarsky)
Comment 3•10 years ago
|
||
Comment on attachment 8431078 [details] [diff] [review] Remove the classinfo for DOMWindowUtils Nice. Sounds like that specialpowers stuff is working. ;) r=me
Attachment #8431078 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Either that, or I had an extremely lucky one here! :-)
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7a5fd3f26e9
Assignee | ||
Comment 6•10 years ago
|
||
So, can we now remove the security checks in nsDOMClassInfo?
Flags: needinfo?(bzbarsky)
Comment 7•10 years ago
|
||
I'm actually not sure. Bobby?
Flags: needinfo?(bzbarsky) → needinfo?(bobbyholley)
Comment 8•10 years ago
|
||
Probably. Which ones are you referring to? Feel free to write a patch and ask me for review.
Flags: needinfo?(bobbyholley)
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c7a5fd3f26e9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 10•10 years ago
|
||
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #6) > So, can we now remove the security checks in nsDOMClassInfo? From bug 1018482, I'm assuming you meant nsDOMWindowUtils here.
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•