Closed Bug 1017820 Opened 7 years ago Closed 7 years ago

Remove the classinfo for DOMWindowUtils

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8431078 [details] [diff] [review]
Remove the classinfo for DOMWindowUtils

https://tbpl.mozilla.org/?tree=Try&rev=2739094b9ab1

I've fixed the test failures after pushing to try.

Note that I removed test_bug397571.html because I don't think that test makes sense any more, as the DOMWindowUtils object should not be accessible to content.
Attachment #8431078 - Flags: review?(bzbarsky)
Comment on attachment 8431078 [details] [diff] [review]
Remove the classinfo for DOMWindowUtils

Nice.  Sounds like that specialpowers stuff is working.  ;)

r=me
Attachment #8431078 - Flags: review?(bzbarsky) → review+
Either that, or I had an extremely lucky one here! :-)
Blocks: stdglobal
So, can we now remove the security checks in nsDOMClassInfo?
Flags: needinfo?(bzbarsky)
I'm actually not sure.  Bobby?
Flags: needinfo?(bzbarsky) → needinfo?(bobbyholley)
Probably. Which ones are you referring to? Feel free to write a patch and ask me for review.
Flags: needinfo?(bobbyholley)
https://hg.mozilla.org/mozilla-central/rev/c7a5fd3f26e9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Blocks: 1018482
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #6)
> So, can we now remove the security checks in nsDOMClassInfo?

From bug 1018482, I'm assuming you meant nsDOMWindowUtils here.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.