1017903 - Synchronous initialization of search service when handling open search tag

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

I'm seeing this warning the first time I load a URL (testing in today's Nightly):

DEPRECATION WARNING: Search service falling back to synchronous initialization. This is generally the consequence of an add-on using a deprecated search service API.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIBrowserSearchService#async_warning
jar:jar:file:///data/app/org.mozilla.fennec-1.apk!/assets/omni.ja!/components/nsSearchService.js 2802 SRCH_SVC__ensureInitialized
jar:jar:file:///data/app/org.mozilla.fennec-1.apk!/assets/omni.ja!/components/nsSearchService.js 3724 SRCH_SVC_getVisible
chrome://browser/content/browser.js 3734 Tab.prototype.handleEvent
null 0 null

I traced this back to this line:
http://hg.mozilla.org/mozilla-central/annotate/b85b57f05fda/mobile/android/chrome/content/browser.js#l3739

We should find a way to do this asynchronously, especially as this could affect load times when loading an external URL on startup.

Comment 1

[Chenxia Liu [:liuche]]

My bad, that should be passed as a callback to Services.search.init. Will be an easy fix though.

Comment 2

[:Margaret Leibovic]

Attachment: Remove synchronous search service initialization

This makes me really want to fix bug 935259, but that's less important.

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8483842 [details] [diff] [review]
Remove synchronous search service initialization

Review of attachment 8483842 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/279d7f0290da

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed this out for a robocop test failure: https://hg.mozilla.org/integration/fx-team/rev/ad3f52e2f336

https://tbpl.mozilla.org/php/getParsedLog.php?id=47516182&tree=Fx-Team

Comment 6

[:Margaret Leibovic]

This is happening because testBrowserDiscovery expects the open search link to be parsed synchronously. 

To work around this, I added a line to testBrowserDiscovery to synchronously load the search service before starting the test, and that fixed things for me locally. Here's a try push:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2b24c7483c39

Comment 7

[:Margaret Leibovic]

Attachment: Load the search service before running open search discovery tests

This seems to solve the problem.

I made a few retriggers to make sure the green wasn't a fluke.

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/731c6ccfc19c
https://hg.mozilla.org/integration/fx-team/rev/49ae569b8536

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/731c6ccfc19c
https://hg.mozilla.org/mozilla-central/rev/49ae569b8536