Closed Bug 1017931 Opened 6 years ago Closed 5 years ago

Allow about:accounts to be used before Sync is configured for FxA

Categories

(Firefox :: Sync, defect)

defect
Not set
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 36
Iteration:
36.3

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently about:accounts is blank if Sync is not configured for FxA - the intent being to not show the ability to login to FxA if Sync is already configured for a legacy account.

This will need to be tweaked for the migration process - it will be necessary for the user to perform an FxA login *before* we have reset Sync - ie, during the migration process there will be a period where Sync is still configured with the legacy account and the user must be logged in to FxA so the migration can complete.

On one hand, it might be reasonable to assume that this state implies the user has opted to upgrade their sync account - however, we will also need to take into account the user might type about:accounts into the URL bar.

Blocking the UX breakdown to determine how about:accounts should change to reflect these states.  A straw man:

1) about:accounts checks (a pref?) to see if a migration is in progress.  If so, just allow it as normal.
2) If no migration is in place, it could serve as an entry-point to the migration process (ie, offer to migrate with a button to start the migration process.  Clicking this button would end up setting that pref and starting the migration process, meaning when about:accounts is re-displayed as part of the migration, it acts as in (1)
Flags: firefox-backlog+
Whiteboard: p=3 → p=3 [qa?]
Whiteboard: p=3 [qa?] → p=3 [qa+]
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Whiteboard: p=3 [qa+] → p=3 s=33.1 [qa+]
The trivial patch.  I'm not going to ask for review until some more of the migration pieces are in place.
Iteration: --- → 33.2
Points: --- → 3
QA Whiteboard: [qa+]
Whiteboard: p=3 s=33.1 [qa+]
Iteration: 33.2 → ---
This should block the actual migration, not the UX breakdown.
Blocks: 999910
No longer blocks: 1014412
QA Whiteboard: [qa+]
Flags: qe-verify+
Assignee: mhammond → nobody
Status: ASSIGNED → NEW
I see no reason to believe this is going to need to change, so might as well get it off the list :)  This patch is the same as the previous one, except the "weave" variable used by the removed block is also removed.  Test pass.
Assignee: nobody → mhammond
Attachment #8438148 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8520315 - Flags: review?(adw)
Iteration: --- → 36.3
Comment on attachment 8520315 [details] [diff] [review]
0006-Bug-1017931-allow-about-accounts-to-be-used-even-if-.patch

Review of attachment 8520315 [details] [diff] [review]:
-----------------------------------------------------------------

It might make sense to skip the "Welcome to Sync" page and jump right to the "Create a Firefox Account" page in this case.  If I know and am already using old Sync, seeing "Welcome to Sync, Get Started" might be strange -- I'm already using it.

Or maybe that's a criticism of how FxA and new Sync are conflated on about:accounts.
Attachment #8520315 - Flags: review?(adw) → review+
(In reply to Drew Willcoxon :adw from comment #4)
> It might make sense to skip the "Welcome to Sync" page and jump right to the
> "Create a Firefox Account" page in this case.

Yeah, this patch will still allow an action=signup etc query param, and I suspect you are correct in that we will choose to use that for the migration entry-points.

> Or maybe that's a criticism of how FxA and new Sync are conflated on
> about:accounts.

Yes, that too :)
https://hg.mozilla.org/mozilla-central/rev/b9f99bf668a9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Which page should be displayed after all? "Welcome to Sync" or  "Create a Firefox Account"?

The current behavior in Firefox 36 beta 1 (build ID: 20150114125146) on about:accounts page is to display "Welcome to Sync". 
If this is the expected behavior then we can consider this issue verified.
Flags: needinfo?(mhammond)
(In reply to Cornel Ionce [QA] from comment #8)
> The current behavior in Firefox 36 beta 1 (build ID: 20150114125146) on
> about:accounts page is to display "Welcome to Sync". 
> If this is the expected behavior then we can consider this issue verified.

Yep, that's correct, thanks.
Status: RESOLVED → VERIFIED
Flags: needinfo?(mhammond)
You need to log in before you can comment on or make changes to this bug.