1017966 - [Flame][V1.4][Dialer]There is no prompts when you tap on "Call" without any number in the dialer field.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[panda67231]

Attachment: attachment.rar

[1.Description]: 
When there is no MO call history, tap on "Call" button, user can't be informed no dialing action will be executed.

Attach the video: Video_Redial.mp4
Attach the logs: bugreport_Redial.txt & logcat_Redial.txt

Happened time: 5:00PM

[2.Testing Steps]: 
Preconditions: a. There is no MO call history; 2. Dialer field is empty - no number has been typed in the field  
1. Launch Dialer app 
2.. Tap on "Call" with out any number in the dialer field 

[3.Expected Result]: 
2.User should be informed no dialing action will be executed  

[4.Actual Result]: 
2.There is no prompts when you tap on "Call" without any number in the dialer field.

[5.Reproduction build]: 
Gaia        7709936aeb21859d1607dbd038489493803bb085
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/5bf038fae0f1
BuildID    20140522160202
Version    30.0

[6.Reproduction Frequency]: Always Recurrence,5/5

Comment 1

[Doug Sherk (:drs) (inactive)]

This issue still occurs on master.

We could fix it by just greying out the call button if there is both: 1. no call history, and 2. no digits entered. Or we could display an error message when tapping the call button. Carrie, what do you think?

Comment 2

[Carrie Wang [New account: [e-mail]]]

Hi, please grey out the button rather than displaying an error message. It will be too much and looks like something really bad just happened. Thanks!

Comment 3

[Kai-Chih Hu [:khu]]

Agreed that to grey out is a better idea. 

After checking the codes, looks like the ID of the button is "keypad-callbar-call-action". But, don't know how to do the control here.

Comment 4

[Rohan Rawat]

Ok, so I have managed to disable the button, but I am not sure how to grey it out. Is there any 'disabled caller' icon available ?

Comment 5

[Rohan Rawat]

Attachment: Disable the call button if the dialer field is empty

Comment 6

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8542546 [details] [review]
Disable the call button if the dialer field is empty

Simple and clean. However, this needs some tests added as I mentioned in the PR. If you need help with this, let me know.

Please also post a screenshot of the disabled button and flag Carol Huang (:Carol) for ui-review.

Thanks for your participation!

Comment 7

[Rohan Rawat]

Attachment: Disabled call button

Yes Doug, I would like your help with testing. I am available on #gaia right now

Comment 8

[Carol Huang [:Carol]]

Comment on attachment 8542819 [details]
Disabled call button

Hi,
The call disable state should be the same as the "add to contact" button(disable state) on the left.Thanks!!

Comment 9

[Rohan Rawat]

Attachment: Disabled call button

Comment 10

[Carol Huang [:Carol]]

Attachment: images_0113.zip

Hey Rohan,
Could you help replace the call icon for the disabled state!Thank you!!
Sorry, I thought it was a SVG file :P

Comment 11

[Carol Huang [:Carol]]

Comment on attachment 8545864 [details]
Disabled call button

please replace the new 'Call' images, thanks!

Comment 12

[Doug Sherk (:drs) (inactive)]

Rohan, do you still need help with this?

Comment 13

[Rohan Rawat]

Attachment: Error.png

Carol, as you can see from the attachment, the disabled call button(grey) is smaller than the active button(white). I am not sure if this is right.

Comment 14

[Carol Huang [:Carol]]

Attachment: images.zip

Hi Rohan,
Could you help me replace the call icons?
I've updated the 2 states of the images. (normal/disable)

Let me know if there's any other question.
Thanks so much!!

Comment 15

[Rohan Rawat]

Attachment: Disabled and enabled call button

Hey Carol, I have replaced the call icons with the one you attached. PLease review.

Comment 16

[Rohan Rawat]

Comment on attachment 8542546 [details] [review]
Disable the call button if the dialer field is empty

Hello Doug, I have made the changes as you requested. Please review.

Comment 17

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8542546 [details] [review]
Disable the call button if the dialer field is empty

Thanks for sticking with this! Unfortunately, we need some more tests to get r+. If you have any questions, feel free to needinfo me or ping me on IRC. My nick is "drs".

Comment 18

[Carol Huang [:Carol]]

Comment on attachment 8550253 [details]
Disabled and enabled call button

Thank you, Rohan!

Comment 19

[Orvi]

I am solving this

Comment 20

[Rohan Rawat]

Comment on attachment 8542546 [details] [review]
Disable the call button if the dialer field is empty

I have added some unit tests

Comment 21

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8542546 [details] [review]
Disable the call button if the dialer field is empty

Rohan, please add the 'checkin-needed' keyword to this bug when you're ready to check this in.

Comment 22

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/2b84f08d6c0f2a6cba5620c1442fd01b9e7dbfac

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing the exact same Gaia unit test failures that were visible in the Gaia Try run on the Pull Request. Please verify your test runs before landing in the future.

Master: https://github.com/mozilla-b2g/gaia/commit/eff3321ab4e65da3f906688ebb55ddf1e93d9452

Comment 24

[Doug Sherk (:drs) (inactive)]

Sorry, that was my fault for a) not checking that the tests all pass and b) not explaining that we need to look at them and fix them if they're failing.

Rohan, you can check your test results on the PR. For example, it says "Rohan Rawat (rohan013) started tests. Results"

Sometimes you will get an orange or red when there's actually nothing wrong, or your patch isn't at fault. If this happens, ask me and we'll go over it together to be sure. Otherwise, if one of the tests that is affected by your patch is failing, you need to fix it before landing.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

And Gaia JS integration test failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=1447338&repo=b2g-inbound

Comment 26

[BMO Automation]

Firefox OS is not being worked on