1018061 - Use mozilla::pkix::der::Input::EnsureLength more consistently

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: consistent-EnsureLength-usage.patch

1. Switch Input::Read() to use EnsureLength() instead of its own checks.
2. Replace the redundant and unconventional pattern of:

   if (EnsureLength(x) != Success) {
     return Fail(SEC_ERROR_BAD_DER);
   }

   with:

   if (EnsureLength(x) != Success) {
     return Failure;
   }

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a49fdbf8041

Thanks for the review!

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a49fdbf8041