1018081 - Should disable ftu and lockscreen in gaia profile by default

Status: RESOLVED INCOMPLETE

(Testing Graveyard :: JSMarionette, defect)

Comment 1

[Evan Tseng [:evanxd]]

We should just disable the lockscreen and ftu by default. Because marionette tests of each app should just take care of itself.

Comment 2

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19813

Comment 3

[Evan Tseng [:evanxd]]

And it also saves time of running tests.

Comment 4

[Evan Tseng [:evanxd]]

How do you guys think about this?

Comment 5

[Evan Tseng [:evanxd]]

Many tests just doesn't need lockscreen and ftu to test their apps. So we could just disable lockscreen and ftu by default to instead of disabling them manually in each test. For example, the below tests just disable them manually in gaia code base.

1. https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/test/marionette/lib/dialer.js#L17
2. https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/test/performance/call_log_rendering_test.js#L15
3. https://github.com/mozilla-b2g/gaia/blob/master/apps/findmydevice/test/marionette/findmydevice_test.js#L13
4. https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/test/marionette/active_icons_test.js#L9
5. https://github.com/mozilla-b2g/gaia/blob/master/apps/music/test/marionette/Player_test.js:#L24
6. https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/performance/overfill_ratio_test.js#L13
7. https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/performance/rendering_wifi_list_test.js#L16
8. https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/test/marionette/phone_number_service_test.js#L10
9. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/activity_callee_alert_test.js#L12
10. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/app_close_test.js#L9
11. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/camera_on_call_test.js#L13
12. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/desktop_notification_test.js#L8
13. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/edges_gesture_test.js#L21
14. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/fullscreen_app_alert_test.js#L13
15. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/fullscreen_statusbar_test.js#L15
16. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/homescreen_navigation_test.js#L18
17. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/install_ime_test.js#L11
18. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/lockscreen_disabled_test.js#L18
19. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/media_playback_test.js#L17
20. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/net_error_test.js#L7
21. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/notification_events_test.js#L14
22. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/notification_get_test.js#L12
23. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/notification_launch_app.js#L11
24. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/notification_resend_test.js#L14
25. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/sim_dialog_test.js#L16
26. https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/lib/rocketbar.js#L28
27. https://github.com/mozilla-b2g/gaia/blob/master/dev_apps/home2/test/marionette/lib/home2.js#L19
28. https://github.com/mozilla-b2g/gaia/blob/master/tests/performance/startup_events_test.js#L41
29. https://github.com/mozilla-b2g/gaia/blob/master/tests/performance/startup_test.js#L20

Comment 6

[Evan Tseng [:evanxd]]

And we also need to fix some tests[1], if we decide to disable ftu and lockscreen by default. We could just enable the ftu or lockscreen manually in the tests to fix the them.

[1] https://travis-ci.org/mozilla-b2g/gaia/jobs/26366598#L2981

Comment 7

[Kevin Grandon :kgrandon]

Sounds good to me! These tests have started timing out a lot on travis (50+ mins), so saving some time would be nice.

Comment 8

[Evan Tseng [:evanxd]]

Hi Kevin,
So let's do this.
Thanks.

Comment 9

[James Lal [:lightsofapollo]]

wfm too

Comment 10

[Firefox Bug Husbandry Bot]

Bulk closed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1422750