1018125 - test_closing_connections.html is broken after bug 868439

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://hg.mozilla.org/mozilla-central/file/38c5e21a80fa/content/media/test/test_closing_connections.html#l38

beginTest could be called after window.onload which will break the purpose of this test case.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Is it necessary to change the pref value of "media.cache_size"?

Comment 2

[Matthew Gregan [:kinetik]]

Yes, it must be small enough to force the cache to close connections for the test to be valid.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

http://hg.mozilla.org/mozilla-central/file/38c5e21a80fa/content/media/test/test_closing_connections.html#l27

Is the "per-domain HTTP connection limit" imposed by the media cache? It appears to me that we should pass the test no matter what the media cache size is.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Matthew Gregan [:kinetik] from comment #2)
> Yes, it must be small enough to force the cache to close connections for the
> test to be valid.

http://hg.mozilla.org/mozilla-central/file/38c5e21a80fa/content/media/test/test_closing_connections.html#l38

IIRC, 40000 means 40MB which is a big size. I think we can remove the pref change and set 'preload' to 'metadata' (which means downloading enough data for decoding metadata, but no more) to test if we can close connections after downloading just enough data.

Comment 5

[Matthew Gregan [:kinetik]]

(In reply to JW Wang [:jwwang] from comment #4)
> IIRC, 40000 means 40MB which is a big size.

Sorry, you're right.  The default media cache sizes for tests was small, this test was explicitly making it large.

> I think we can remove the pref change and set 'preload' to 'metadata' (which means downloading
> enough data for decoding metadata, but no more) to test if we can close connections
> after downloading just enough data.

That seems reasonable.  I think that's effectively what the test did originally, when it was added with the autobuffer functionality in bug 479863.  The element's default, then, was the equivalent of preload=metadata now, if I understand correctly.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1018125_fix_test_closing_connections_html.patch

Remove SpecialPowers.pushPrefEnv() which delays loading media resources and breaks the purpose of this test.

Try: https://tbpl.mozilla.org/?tree=Try&rev=dd78cbabb01f
     https://tbpl.mozilla.org/?tree=Try&rev=1d9a9d1b8a00

All pass on test_closing_connections.html.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/63cbbdbc8e76

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/63cbbdbc8e76