Closed Bug 1018208 Opened 11 years ago Closed 11 years ago

Write missing tests for Loop "do not disturb" feature

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: NiKo, Unassigned)

References

Details

(Whiteboard: [p=1][qa-])

Attachments

(1 file, 1 obsolete file)

This is a follow up to bug 994152; we're missing tests for ensuring the chat window isn't opened on incoming notifications when the doNotDisturb flag is enabled.
We should probably do these quite early to get them covered in case of regressions (and to ensure we've coverage for parts of loop that aren't covered).
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Whiteboard: [p=1]
Target Milestone: --- → mozilla33
Assignee: nobody → nperriault
Attached patch bug-1018208-missing-tests.patch (obsolete) — Splinter Review
Based on :standard8 initial proposal attached to bug 8427007: https://bug994152.bugzilla.mozilla.org/attachment.cgi?id=8427007
Attachment #8434000 - Flags: review?(standard8)
Comment on attachment 8434000 [details] [diff] [review] bug-1018208-missing-tests.patch Review of attachment 8434000 [details] [diff] [review]: ----------------------------------------------------------------- I think this is reasonable to do. Please can you update it for the promise changes in: https://hg.mozilla.org/projects/elm/rev/f76b6f96fecd and the boiler-plate changes in: https://hg.mozilla.org/projects/elm/rev/1439cebf74e1 Thanks.
Attachment #8434000 - Flags: review?(standard8) → feedback+
Updated patch to match the new fake test server API.
Attachment #8435836 - Flags: review?(standard8)
Comment on attachment 8435836 [details] [diff] [review] bug-1018208-missing-tests-2.patch Review of attachment 8435836 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=Standard8
Attachment #8435836 - Flags: review?(standard8) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
QA Contact: anthony.s.hughes
Whiteboard: [p=1] → [p=1][qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: