Closed
Bug 1018208
Opened 11 years ago
Closed 11 years ago
Write missing tests for Loop "do not disturb" feature
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: NiKo, Unassigned)
References
Details
(Whiteboard: [p=1][qa-])
Attachments
(1 file, 1 obsolete file)
3.55 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
This is a follow up to bug 994152; we're missing tests for ensuring the chat window isn't opened on incoming notifications when the doNotDisturb flag is enabled.
Comment 1•11 years ago
|
||
We should probably do these quite early to get them covered in case of regressions (and to ensure we've coverage for parts of loop that aren't covered).
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Whiteboard: [p=1]
Target Milestone: --- → mozilla33
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → nperriault
Assignee | ||
Comment 2•11 years ago
|
||
Based on :standard8 initial proposal attached to bug 8427007: https://bug994152.bugzilla.mozilla.org/attachment.cgi?id=8427007
Attachment #8434000 -
Flags: review?(standard8)
Comment 3•11 years ago
|
||
Comment on attachment 8434000 [details] [diff] [review]
bug-1018208-missing-tests.patch
Review of attachment 8434000 [details] [diff] [review]:
-----------------------------------------------------------------
I think this is reasonable to do. Please can you update it for the promise changes in:
https://hg.mozilla.org/projects/elm/rev/f76b6f96fecd
and the boiler-plate changes in:
https://hg.mozilla.org/projects/elm/rev/1439cebf74e1
Thanks.
Attachment #8434000 -
Flags: review?(standard8) → feedback+
Assignee | ||
Comment 4•11 years ago
|
||
Updated patch to match the new fake test server API.
Attachment #8435836 -
Flags: review?(standard8)
Assignee | ||
Updated•11 years ago
|
Attachment #8434000 -
Attachment is obsolete: true
Comment 5•11 years ago
|
||
Comment on attachment 8435836 [details] [diff] [review]
bug-1018208-missing-tests-2.patch
Review of attachment 8435836 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, r=Standard8
Attachment #8435836 -
Flags: review?(standard8) → review+
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•