Checkbox "Use as default ringtone" looks bad when translation spans on multiple lines

RESOLVED FIXED

Status

Firefox OS
Gaia::Ringtones
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: flod, Assigned: squib)

Tracking

unspecified
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

4 years ago
Created attachment 8431707 [details]
Screenshot Keon

See attachment: horizontal alignment of the second line is off (minor), the line-height is too big.
(Assignee)

Comment 1

4 years ago
Created attachment 8433638 [details] [review]
Fix it

Here's a fix.

(A part of me thinks I should just redo everything with flexbox, but this works and that's enough for me.)
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attachment #8433638 - Flags: ui-review?(tshakespeare)
Attachment #8433638 - Flags: review?(dflanagan)
(Assignee)

Comment 2

4 years ago
Created attachment 8433639 [details]
Screenshot of the fix
Comment on attachment 8433638 [details] [review]
Fix it

Took a look at the screenshot and things look much better. Thanks Jim!
Attachment #8433638 - Flags: ui-review?(tshakespeare) → ui-review+
Comment on attachment 8433638 [details] [review]
Fix it

looks good to me
Attachment #8433638 - Flags: review?(dflanagan) → review+
(Assignee)

Comment 5

4 years ago
Landed: https://github.com/mozilla-b2g/gaia/pull/19962

Setting in-testsuite to "-" because this is just a CSS change.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
(Assignee)

Comment 6

4 years ago
Created attachment 8433768 [details] [review]
Fix alignment

Whoops, I forgot to save this part of the file originally. This just makes the text centered a little nicer. I verified that this looks the same as it did before I "fixed" this bug. :)
Attachment #8433768 - Flags: review?(dflanagan)
(Assignee)

Updated

4 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

4 years ago
Attachment #8433768 - Flags: review?(dflanagan) → review+
(Assignee)

Comment 7

4 years ago
Checked in: https://github.com/mozilla-b2g/gaia/commit/4fd7953bc0dd0c631814e4cc362c44fa8125ce6f
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.