Closed
Bug 1018322
Opened 11 years ago
Closed 10 years ago
Checkbox "Use as default ringtone" looks bad when translation spans on multiple lines
Categories
(Firefox OS Graveyard :: Gaia::Ringtones, defect)
Firefox OS Graveyard
Gaia::Ringtones
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: squib)
References
Details
Attachments
(4 files)
See attachment: horizontal alignment of the second line is off (minor), the line-height is too big.
Assignee | ||
Comment 1•10 years ago
|
||
Here's a fix.
(A part of me thinks I should just redo everything with flexbox, but this works and that's enough for me.)
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attachment #8433638 -
Flags: ui-review?(tshakespeare)
Attachment #8433638 -
Flags: review?(dflanagan)
Assignee | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8433638 [details] [review]
Fix it
Took a look at the screenshot and things look much better. Thanks Jim!
Attachment #8433638 -
Flags: ui-review?(tshakespeare) → ui-review+
Comment 4•10 years ago
|
||
Comment on attachment 8433638 [details] [review]
Fix it
looks good to me
Attachment #8433638 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/pull/19962
Setting in-testsuite to "-" because this is just a CSS change.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Assignee | ||
Comment 6•10 years ago
|
||
Whoops, I forgot to save this part of the file originally. This just makes the text centered a little nicer. I verified that this looks the same as it did before I "fixed" this bug. :)
Attachment #8433768 -
Flags: review?(dflanagan)
Assignee | ||
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•10 years ago
|
Attachment #8433768 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•